Page MenuHomePhabricator

Clean up some ordering and strata edge cases in Phrequent
ClosedPublic

Authored by epriestley on Oct 18 2013, 9:43 PM.
Tags
None
Referenced Files
F15447624: D7350.id.diff
Fri, Mar 28, 12:42 AM
F15444706: D7350.id16603.diff
Thu, Mar 27, 10:48 AM
Unknown Object (File)
Feb 27 2025, 3:15 AM
Unknown Object (File)
Feb 27 2025, 3:15 AM
Unknown Object (File)
Feb 27 2025, 3:15 AM
Unknown Object (File)
Feb 27 2025, 3:15 AM
Unknown Object (File)
Feb 24 2025, 4:50 AM
Unknown Object (File)
Feb 14 2025, 4:26 AM
Subscribers

Details

Summary

Ref T3569. Two issues:

  1. Since sort() is not stable, instantaneous events (ending on the same second they start) would sometime sort wrong and produce the wrong results. Guarantee they sort correctly.
  2. Because events can end at any time, there are some additional special cases the algorithm didn't handle properly. Draw a bunch of ASCII art diagrams so these cases work properly.
Test Plan
  • No more fatal when tracking an object for the first time.
  • Unit tests.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

"Thank goodness for the ASCII art" the reviewer thought to himself. :D