Page MenuHomePhabricator

Require application "Can Use" capability to call Conduit methods
ClosedPublic

Authored by epriestley on Oct 17 2013, 7:47 PM.
Tags
None
Referenced Files
F15668169: D7342.diff
Sun, May 25, 4:56 PM
Unknown Object (File)
Wed, May 7, 10:13 PM
Unknown Object (File)
Mon, May 5, 9:15 PM
Unknown Object (File)
Wed, Apr 30, 6:00 PM
Unknown Object (File)
Mon, Apr 28, 12:23 PM
Unknown Object (File)
Sun, Apr 27, 11:49 AM
Unknown Object (File)
Sat, Apr 26, 10:48 AM
Unknown Object (File)
Sat, Apr 26, 5:52 AM
Subscribers

Details

Summary

Ref T603. If you don't have access to an application, prevent execution of its (authenticated) methods.

Test Plan

Restricted Tokens to only admins, then tried to view/call Token methods as a non-admin.

Diff Detail

Branch
pconduit
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/conduit/call/ConduitCall.php:94XHP16TODO Comment
Unit
Tests Passed

Event Timeline

I want to clean up Conduit auth at some point -- and maybe sooner than later -- but there are a few related changes (the SSH version, making a more cURL-able version of the API available, formalizing the non-connect version, typechecking, getting rid of differential.anonymous-access, cleaning up the way tokens cycle and we deal with out-of-range client timestmaps) that probably make sense to bundle most of together so all the testing can overlap. That should let us run more of these checks through less total code.