Paths

Table of Contentst

Fix lightbox downloads for embeded images and a warning
ClosedPublic
Actions

Authored by epriestley on Oct 17 2013, 6:16 PM.

Tags

None

Referenced Files

	F18813809: D7341.id.diff
	Mon, Oct 20, 6:59 PM

	F18783018: D7341.diff
	Mon, Oct 13, 3:20 AM

	F18732712: D7341.id.diff
	Tue, Sep 30, 7:29 PM

	F18672779: D7341.id16533.diff
	Sep 25 2025, 8:12 AM

	F18672778: D7341.id16534.diff
	Sep 25 2025, 8:12 AM

	F18672654: D7341.diff
	Sep 25 2025, 8:01 AM

	F18598474: D7341.diff
	Sep 13 2025, 5:08 AM

	F18591790: D7341.diff
	Sep 12 2025, 10:07 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad
dctrwatson

Commits

Restricted Diffusion Commit
rP32dca4b553f8: Fix lightbox downloads for embeded images and a warning

Summary

I refactored this recently and accidentally dropped the download URI.

Also fix a warning with, e.g., files named README.

Test Plan

Clicked a thumb, clicked "Download", got a file.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad accepted this revision.Oct 17 2013, 6:17 PM

Closed by commit rP32dca4b553f8 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

view/

DifferentialChangesetDetailView.php

2 lines

files/

remarkup/

PhabricatorRemarkupRuleEmbedFile.php

1 line

Diff 16534

View Options

src/applications/differential/view/DifferentialChangesetDetailView.php