Page MenuHomePhabricator
Differential D7331

Expand Remarkup interpreter block capabilities a little bit
ClosedPublic
Actions

Authored by epriestley on Oct 16 2013, 7:09 PM.
Tags
None
Referenced Files
F15504831: D7331.id16518.diff
Mon, Apr 14, 9:19 PM
F15449606: D7331.id.diff
Fri, Mar 28, 11:14 AM
F15414078: D7331.id16518.diff
Wed, Mar 19, 11:02 PM
F15408188: D7331.id.diff
Tue, Mar 18, 9:36 PM
F15399231: D7331.diff
Mon, Mar 17, 3:27 AM
F15345260: D7331.diff
Mar 10 2025, 9:23 AM
Unknown Object (File)
Feb 24 2025, 2:57 AM
Unknown Object (File)
Feb 13 2025, 9:57 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T3274: Add Text Macro Generator to Phabricator / Remarkup
T3591: Render PlantUML syntax as macro in remarkup areas.
T3964: graphviz plugin for editor
Commits
rPHUd422741443dd: Expand Remarkup interpreter block capabilities a little bit
Summary

Ref T3274. Ref T3591. Ref T3964. Allows interpreters to access the engine so they can check for text mode, grab the viewer/config, etc.

Also, make the unit tests not depend on trailing whitespace to pass.

Test Plan

See next revision.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Oct 16 2013, 10:42 PM

"I am okay with the lint problem."

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php
11

typehint maybs

epriestley closed this revision.Oct 17 2013, 2:08 AM

Closed by commit rPHUd422741443dd (authored by @epriestley).

Revision Contents
Changeset List

Diff 16518

View Options

src/markup/engine/__tests__/remarkup/interpreter-test.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupInterpreterRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupTestInterpreterRule.php

Loading...
Phabricator · Built by Phacility