Page MenuHomePhabricator
Differential D7331

Expand Remarkup interpreter block capabilities a little bit
ClosedPublic
Actions

Authored by epriestley on Oct 16 2013, 7:09 PM.
Tags
None
Referenced Files
F13055251: D7331.id16509.diff
Fri, Apr 19, 12:33 PM
Unknown Object (File)
Tue, Apr 16, 10:25 PM
Unknown Object (File)
Thu, Apr 11, 5:44 AM
Unknown Object (File)
Wed, Apr 3, 1:58 AM
Unknown Object (File)
Sun, Mar 31, 5:02 PM
Unknown Object (File)
Sat, Mar 23, 5:34 AM
Unknown Object (File)
Jan 21 2024, 12:35 PM
Unknown Object (File)
Jan 19 2024, 7:07 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T3274: Add Text Macro Generator to Phabricator / Remarkup
T3591: Render PlantUML syntax as macro in remarkup areas.
T3964: graphviz plugin for editor
Commits
rPHUd422741443dd: Expand Remarkup interpreter block capabilities a little bit
Summary

Ref T3274. Ref T3591. Ref T3964. Allows interpreters to access the engine so they can check for text mode, grab the viewer/config, etc.

Also, make the unit tests not depend on trailing whitespace to pass.

Test Plan

See next revision.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Oct 16 2013, 10:42 PM

"I am okay with the lint problem."

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php
11

typehint maybs

epriestley closed this revision.Oct 17 2013, 2:08 AM

Closed by commit rPHUd422741443dd (authored by @epriestley).

Revision Contents
Changeset List

Diff 16518

View Options

src/markup/engine/__tests__/remarkup/interpreter-test.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupInterpreterRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupTestInterpreterRule.php

Loading...
Phabricator · Built by Phacility