Expand Remarkup interpreter block capabilities a little bit
ClosedPublic
Actions

Authored by epriestley on Oct 16 2013, 7:09 PM.

Tags

None

Referenced Files

	F19507982: D7331.diff
	Sat, Jan 10, 12:23 AM

	F19080822: D7331.diff
	Dec 2 2025, 2:32 AM

	F19030503: D7331.diff
	Nov 24 2025, 9:25 PM

	F19022911: D7331.diff
	Nov 23 2025, 10:29 PM

	F19018021: D7331.diff
	Nov 23 2025, 10:03 AM

	F18853870: D7331.id.diff
	Oct 31 2025, 8:11 PM

	F18847823: D7331.diff
	Oct 30 2025, 2:24 AM

	F18701526: D7331.id.diff
	Sep 27 2025, 7:42 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T3274: Add Text Macro Generator to Phabricator / Remarkup
T3591: Render PlantUML syntax as macro in remarkup areas.
T3964: graphviz plugin for editor

Commits

rPHUd422741443dd: Expand Remarkup interpreter block capabilities a little bit

Summary

Ref T3274. Ref T3591. Ref T3964. Allows interpreters to access the engine so they can check for text mode, grab the viewer/config, etc.

Also, make the unit tests not depend on trailing whitespace to pass.

Test Plan

See next revision.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

"I am okay with the lint problem."

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php
11	typehint maybs

Closed by commit rPHUd422741443dd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

interpreter-test.txt

32 lines

remarkup/

blockrule/

PhutilRemarkupBlockInterpreter.php

24 lines

PhutilRemarkupEngineRemarkupInterpreterRule.php

13 lines

PhutilRemarkupEngineRemarkupTestInterpreterRule.php

2 lines

Diff 16518

View Options

src/markup/engine/tests/remarkup/interpreter-test.txt

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupInterpreterRule.php

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupTestInterpreterRule.php

Expand Remarkup interpreter block capabilities a little bitClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16518

src/markup/engine/__tests__/remarkup/interpreter-test.txt

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupInterpreterRule.php

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupTestInterpreterRule.php

Expand Remarkup interpreter block capabilities a little bit
ClosedPublic
Actions

Revision Contents
Changeset List

src/markup/engine/tests/remarkup/interpreter-test.txt