Page MenuHomePhabricator

Misc Diffusion/Differential CSS tweaks
ClosedPublic

Authored by chad on Oct 15 2013, 6:51 PM.
Tags
None
Referenced Files
F14699673: D7325.id16512.diff
Tue, Jan 14, 12:31 PM
Unknown Object (File)
Sun, Jan 5, 10:35 PM
Unknown Object (File)
Fri, Jan 3, 5:25 PM
Unknown Object (File)
Fri, Jan 3, 3:50 AM
Unknown Object (File)
Wed, Dec 25, 5:29 AM
Unknown Object (File)
Wed, Dec 25, 5:29 AM
Unknown Object (File)
Wed, Dec 25, 5:17 AM
Unknown Object (File)
Tue, Dec 24, 1:53 PM

Details

Summary

Various tweaks and fixes. Adds a File Contents view in Diffusion, normalizes spaces, colors.

Test Plan

tested differential and diffusion in my sandbox.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I'd like to make a more dramatic attack on that "giant mess of green" in the left columns at some point, but this is clearly a large step forward.

In particular, we currently show three columns:

| af832938 | D1234 | alincoln |

I think we could get away with this:

| D1234 / af832938 |

..and a hovercard/tooltip on the af832938 bit, showing the title/author/date/etc.

And then we could probably lose the shading on the number column, and make the "<<" a more prominent, easier-to-see/hit button.

yeah let me get that too. i was ignoring but it could use some love.

Oh, some of that might be a huge pain because of how it gets built -- if you run into a bunch of JS that makes zero sense, I can probably untangle that. This code got some cleanup recently but needs some more.

ok, i'll land and work on diffusion more. any other pain points?

That's the only one on my radar, I think.