Page MenuHomePhabricator

Fix a lexer issue with SimpleOptions and backslashes in unterminated quotes
ClosedPublic

Authored by epriestley on Oct 15 2013, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 8:44 PM
Unknown Object (File)
Thu, Nov 21, 5:30 PM
Unknown Object (File)
Mon, Nov 18, 3:12 AM
Unknown Object (File)
Wed, Nov 13, 4:34 PM
Unknown Object (File)
Mon, Nov 11, 12:25 AM
Unknown Object (File)
Sun, Nov 10, 3:45 PM
Unknown Object (File)
Tue, Nov 5, 6:50 PM
Unknown Object (File)
Oct 26 2024, 9:17 AM
Subscribers

Details

Summary

The SimpleOptions lexer has an error when parsing a line like a="\, where the lexer can't accept the backslash inside the unterminated quotes.

Test Plan

Added failing unit tests; they now pass.

Diff Detail

Branch
simpleoptions
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

Pulled in and confirmed this fixes the bug