Page MenuHomePhabricator

Fix a lexer issue with SimpleOptions and backslashes in unterminated quotes
ClosedPublic

Authored by epriestley on Oct 15 2013, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 26 2025, 2:43 PM
Unknown Object (File)
Jun 17 2025, 10:15 PM
Unknown Object (File)
Jun 16 2025, 8:25 AM
Unknown Object (File)
Jun 7 2025, 3:01 AM
Unknown Object (File)
May 10 2025, 11:36 PM
Unknown Object (File)
Apr 21 2025, 4:30 AM
Unknown Object (File)
Mar 22 2025, 2:36 PM
Unknown Object (File)
Mar 21 2025, 2:53 AM
Subscribers

Details

Summary

The SimpleOptions lexer has an error when parsing a line like a="\, where the lexer can't accept the backslash inside the unterminated quotes.

Test Plan

Added failing unit tests; they now pass.

Diff Detail

Branch
simpleoptions
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

Pulled in and confirmed this fixes the bug