Paths

Table of Contentst

Fix a lexer issue with SimpleOptions and backslashes in unterminated quotes
ClosedPublic
Actions

Authored by epriestley on Oct 15 2013, 1:53 PM.

Tags

None

Referenced Files

	F15423299: D7323.id16493.diff
	Sat, Mar 22, 2:36 PM

	F15419024: D7323.id16493.diff
	Fri, Mar 21, 2:53 AM

	F15408752: D7323.id.diff
	Wed, Mar 19, 1:05 AM

	F15399979: D7323.diff
	Mon, Mar 17, 8:54 AM

	Unknown Object (File)
	Mon, Feb 24, 2:56 AM

	Unknown Object (File)
	Feb 13 2025, 9:57 PM

	Unknown Object (File)
	Feb 3 2025, 9:42 AM

	Unknown Object (File)
	Jan 31 2025, 9:58 AM

View All Files

Subscribers

aran

SEJeff

Details

Reviewers

btrahan
SEJeff

Commits

rPHUaa45dfcc2c33: Fix a lexer issue with SimpleOptions and backslashes in unterminated quotes

Summary

The SimpleOptions lexer has an error when parsing a line like a="\, where the lexer can't accept the backslash inside the unterminated quotes.

Test Plan

Added failing unit tests; they now pass.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Pulled in and confirmed this fixes the bug

Closed by commit rPHUaa45dfcc2c33 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lexer/

PhutilLexer.php

1 line

PhutilSimpleOptionsLexer.php

2 lines

parser/

__tests__/

PhutilSimpleOptionsTestCase.php

19 lines

Diff 16493

View Options

src/lexer/PhutilLexer.php

View Options

src/lexer/PhutilSimpleOptionsLexer.php

View Options

src/parser/tests/PhutilSimpleOptionsTestCase.php

Fix a lexer issue with SimpleOptions and backslashes in unterminated quotesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16493

src/lexer/PhutilLexer.php

src/lexer/PhutilSimpleOptionsLexer.php

src/parser/__tests__/PhutilSimpleOptionsTestCase.php

Fix a lexer issue with SimpleOptions and backslashes in unterminated quotes
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/tests/PhutilSimpleOptionsTestCase.php