Page MenuHomePhabricator
Differential D7323

Fix a lexer issue with SimpleOptions and backslashes in unterminated quotes
ClosedPublic
Actions

Authored by epriestley on Oct 15 2013, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 8:44 PM
Unknown Object (File)
Thu, Nov 21, 5:30 PM
Unknown Object (File)
Mon, Nov 18, 3:12 AM
Unknown Object (File)
Wed, Nov 13, 4:34 PM
Unknown Object (File)
Mon, Nov 11, 12:25 AM
Unknown Object (File)
Sun, Nov 10, 3:45 PM
Unknown Object (File)
Tue, Nov 5, 6:50 PM
Unknown Object (File)
Oct 26 2024, 9:17 AM
View All Files
Subscribers
aran
SEJeff

Details

Reviewers
btrahan
SEJeff
Commits
rPHUaa45dfcc2c33: Fix a lexer issue with SimpleOptions and backslashes in unterminated quotes
Summary

The SimpleOptions lexer has an error when parsing a line like a="\, where the lexer can't accept the backslash inside the unterminated quotes.

Test Plan

Added failing unit tests; they now pass.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

SEJeff accepted this revision.Oct 15 2013, 4:00 PM

Pulled in and confirmed this fixes the bug

epriestley closed this revision.Oct 15 2013, 4:03 PM

Closed by commit rPHUaa45dfcc2c33 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
lexer/
1 line
2 lines
parser/
__tests__/
19 lines

Diff 16493

View Options

src/lexer/PhutilLexer.php

Loading...
View Options

src/lexer/PhutilSimpleOptionsLexer.php

Loading...
View Options

src/parser/__tests__/PhutilSimpleOptionsTestCase.php

Loading...
Phabricator · Built by Phacility