Generalize Herald account sources
ClosedPublic
Actions

Authored by epriestley on Oct 15 2013, 2:37 AM.

Tags

None

Referenced Files

	F17738305: D7319.diff
	Sun, Jul 20, 11:22 PM

	Unknown Object (File)
	May 10 2025, 11:29 AM

	Unknown Object (File)
	May 8 2025, 7:47 AM

	Unknown Object (File)
	Apr 18 2025, 12:53 AM

	Unknown Object (File)
	Mar 30 2025, 5:02 PM

	Unknown Object (File)
	Mar 14 2025, 8:52 PM

	Unknown Object (File)
	Mar 8 2025, 3:43 PM

	Unknown Object (File)
	Feb 14 2025, 2:38 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
bigo

Commits

Restricted Diffusion Commit
rP19968e31f4bf: Generalize Herald account sources

Summary

The "user" and "user/project" sources exclude system agents and disabled users, but should not.

Test Plan

Added system agents to Herald rules.

Diff Detail

Branch

hsources

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

i accept this, but only because it does exactly what i want it to

Closed by commit rP19968e31f4bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldRuleController.php

4 lines

Diff 16485

View Options

src/applications/herald/controller/HeraldRuleController.php

Generalize Herald account sourcesClosedPublicActions