Generalize Herald account sources
ClosedPublic
Actions

Authored by epriestley on Oct 15 2013, 2:37 AM.

Tags

None

Referenced Files

	F15514148: D7319.diff
	Fri, Apr 18, 12:53 AM

	F15457467: D7319.diff
	Mar 30 2025, 5:02 PM

	F15384797: D7319.id16485.diff
	Mar 14 2025, 8:52 PM

	F15335471: D7319.diff
	Mar 8 2025, 3:43 PM

	Unknown Object (File)
	Feb 14 2025, 2:38 PM

	Unknown Object (File)
	Feb 7 2025, 9:42 AM

	Unknown Object (File)
	Feb 7 2025, 9:42 AM

	Unknown Object (File)
	Feb 7 2025, 8:37 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
bigo

Commits

Restricted Diffusion Commit
rP19968e31f4bf: Generalize Herald account sources

Summary

The "user" and "user/project" sources exclude system agents and disabled users, but should not.

Test Plan

Added system agents to Herald rules.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

i accept this, but only because it does exactly what i want it to

Closed by commit rP19968e31f4bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldRuleController.php

4 lines

Diff 16486

View Options

src/applications/herald/controller/HeraldRuleController.php

Generalize Herald account sourcesClosedPublicActions