Generalize Herald account sources
ClosedPublic
Actions

Authored by epriestley on Oct 15 2013, 2:37 AM.

Tags

None

Referenced Files

	F18831951: D7319.id.diff
	Sat, Oct 25, 5:37 PM

	F18795802: D7319.diff
	Fri, Oct 17, 2:29 AM

	F18669182: D7319.id.diff
	Sep 24 2025, 7:13 PM

	F18586253: D7319.id16485.diff
	Sep 11 2025, 5:58 PM

	F18579360: D7319.diff
	Sep 11 2025, 12:29 AM

	F18172036: D7319.id16485.diff
	Aug 15 2025, 6:48 PM

	F18157958: D7319.diff
	Aug 14 2025, 10:35 PM

	F17997273: D7319.id16486.diff
	Aug 2 2025, 4:58 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
bigo

Commits

Restricted Diffusion Commit
rP19968e31f4bf: Generalize Herald account sources

Summary

The "user" and "user/project" sources exclude system agents and disabled users, but should not.

Test Plan

Added system agents to Herald rules.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

i accept this, but only because it does exactly what i want it to

Closed by commit rP19968e31f4bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldRuleController.php

4 lines

Diff 16486

View Options

src/applications/herald/controller/HeraldRuleController.php

Generalize Herald account sourcesClosedPublicActions