Generalize Herald account sources
ClosedPublic
Actions

Authored by epriestley on Oct 15 2013, 2:37 AM.

Tags

None

Referenced Files

	F13210431: D7319.diff
	Fri, May 17, 4:50 AM

	F13196084: D7319.diff
	Sun, May 12, 10:55 PM

	Unknown Object (File)
	Fri, May 3, 2:37 AM

	Unknown Object (File)
	Thu, May 2, 3:56 AM

	Unknown Object (File)
	Mon, Apr 29, 2:06 PM

	Unknown Object (File)
	Wed, Apr 24, 9:56 PM

	Unknown Object (File)
	Sun, Apr 21, 11:12 PM

	Unknown Object (File)
	Sun, Apr 21, 4:20 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
bigo

Commits

Restricted Diffusion Commit
rP19968e31f4bf: Generalize Herald account sources

Summary

The "user" and "user/project" sources exclude system agents and disabled users, but should not.

Test Plan

Added system agents to Herald rules.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

i accept this, but only because it does exactly what i want it to

Closed by commit rP19968e31f4bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldRuleController.php

4 lines

Diff 16486

View Options

src/applications/herald/controller/HeraldRuleController.php

Generalize Herald account sourcesClosedPublicActions