Generalize Herald account sources
ClosedPublic
Actions

Authored by epriestley on Oct 15 2013, 2:37 AM.

Tags

None

Referenced Files

	F14065641: D7319.diff
	Tue, Nov 19, 5:42 AM

	F14052813: D7319.diff
	Fri, Nov 15, 11:02 AM

	F14037905: D7319.diff
	Sun, Nov 10, 8:02 PM

	F14036791: D7319.id16485.diff
	Sun, Nov 10, 12:08 PM

	F14022376: D7319.diff
	Wed, Nov 6, 4:56 PM

	Unknown Object (File)
	Oct 2 2024, 7:49 PM

	Unknown Object (File)
	Oct 2 2024, 7:19 AM

	Unknown Object (File)
	Sep 16 2024, 7:26 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
bigo

Commits

Restricted Diffusion Commit
rP19968e31f4bf: Generalize Herald account sources

Summary

The "user" and "user/project" sources exclude system agents and disabled users, but should not.

Test Plan

Added system agents to Herald rules.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

i accept this, but only because it does exactly what i want it to

Closed by commit rP19968e31f4bf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldRuleController.php

4 lines

Diff 16486

View Options

src/applications/herald/controller/HeraldRuleController.php

Generalize Herald account sourcesClosedPublicActions