Page MenuHomePhabricator

Add some topographical sorting stuff
ClosedPublic

Authored by btrahan on Oct 14 2013, 11:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 2:56 AM
Unknown Object (File)
Tue, Feb 18, 8:58 AM
Unknown Object (File)
Jan 27 2025, 4:57 PM
Unknown Object (File)
Jan 21 2025, 3:16 AM
Unknown Object (File)
Jan 17 2025, 8:32 PM
Unknown Object (File)
Jan 11 2025, 11:39 PM
Unknown Object (File)
Jan 2 2025, 2:17 PM
Unknown Object (File)
Dec 25 2024, 2:08 PM

Details

Summary

I need this to be able to apply dependencies in a working order for arc patch (T479). I feel like the names are wonky here so I appreciate suggestions. Also maybe more test cases?

Test Plan

ran unit tests

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

One inline, the rest look sane.

src/utils/AbstractDirectedGraph.php
102

I don't have a fancy CS degree, but I think this should be "topogr..", not "tophr..".

135

Consider using keys so this can be an O(1) unset() instead of an O(N) array_diff().

src/utils/AbstractDirectedGraph.php
102

lol. I think mine burned in a fier.

btrahan updated this revision to Unknown Object (????).Oct 15 2013, 6:06 PM

fix my spelling

better data structure for better perfz