Page MenuHomePhabricator

Add some topographical sorting stuff
ClosedPublic

Authored by btrahan on Oct 14 2013, 11:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 5:12 AM
Unknown Object (File)
Tue, Nov 19, 7:39 PM
Unknown Object (File)
Sat, Nov 16, 5:57 AM
Unknown Object (File)
Tue, Nov 12, 6:04 AM
Unknown Object (File)
Sun, Nov 10, 10:32 AM
Unknown Object (File)
Fri, Nov 8, 9:37 AM
Unknown Object (File)
Oct 14 2024, 11:43 PM
Unknown Object (File)
Oct 13 2024, 6:08 AM

Details

Summary

I need this to be able to apply dependencies in a working order for arc patch (T479). I feel like the names are wonky here so I appreciate suggestions. Also maybe more test cases?

Test Plan

ran unit tests

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

One inline, the rest look sane.

src/utils/AbstractDirectedGraph.php
102

I don't have a fancy CS degree, but I think this should be "topogr..", not "tophr..".

135

Consider using keys so this can be an O(1) unset() instead of an O(N) array_diff().

src/utils/AbstractDirectedGraph.php
102

lol. I think mine burned in a fier.

btrahan updated this revision to Unknown Object (????).Oct 15 2013, 6:06 PM

fix my spelling

better data structure for better perfz