Add some topographical sorting stuff
ClosedPublic
Actions

Authored by btrahan on Oct 14 2013, 11:27 PM.

Tags

None

Referenced Files

	F15416736: D7315.id16497.diff
	Thu, Mar 20, 1:15 PM

	F15415016: D7315.diff
	Thu, Mar 20, 3:33 AM

	F15396307: D7315.id16496.diff
	Sun, Mar 16, 1:24 PM

	F15385365: D7315.id16497.diff
	Fri, Mar 14, 10:22 PM

	F15378568: D7315.diff
	Thu, Mar 13, 3:20 PM

	Unknown Object (File)
	Sun, Mar 2, 6:13 PM

	Unknown Object (File)
	Wed, Feb 26, 10:02 PM

	Unknown Object (File)
	Mon, Feb 24, 2:56 AM

Subscribers

Details

Reviewers

epriestley

Commits

rPHU47ccf3f3cdd2: Add some topographical sorting stuff

Summary

I need this to be able to apply dependencies in a working order for arc patch (T479). I feel like the names are wonky here so I appreciate suggestions. Also maybe more test cases?

Test Plan

ran unit tests

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

One inline, the rest look sane.

src/utils/AbstractDirectedGraph.php
102	I don't have a fancy CS degree, but I think this should be "topogr..", not "tophr..".
135	Consider using keys so this can be an O(1) `unset()` instead of an O(N) `array_diff()`.