Page MenuHomePhabricator

Maniphest - add support for !assign command
ClosedPublic

Authored by btrahan on Oct 14 2013, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 10:12 PM
Unknown Object (File)
Wed, Dec 25, 7:37 AM
Unknown Object (File)
Wed, Dec 25, 7:37 AM
Unknown Object (File)
Wed, Dec 25, 7:37 AM
Unknown Object (File)
Wed, Dec 25, 7:25 AM
Unknown Object (File)
Sat, Dec 21, 3:02 AM
Unknown Object (File)
Sun, Dec 15, 4:46 PM
Unknown Object (File)
Wed, Dec 11, 1:19 AM

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPd0127f95e541: Maniphest - add support for !assign command
Summary

also try to centralize some of the command parsing logic. note that differential is still an exception here. it uses a whitelist-style regex. i think long-term we should have this for every app but changing it seemed too big for this diff.

Fixes T3937.

Test Plan

echo '!assign btrahan' | ./bin/mail receive-test --as xerxes --to T22 ; echo '!claim' | ./bin/mail receive-test --as xerxes --to T22

unit tests passed, though my new one is silly

Diff Detail

Branch
T3937
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

Nice, this is definitely a lot cleaner. Agreed on the long term vision and also on there being more mess here than fits in one diff.

src/applications/maniphest/mail/ManiphestReplyHandler.php
95–102

Maybe just execute() and then check if you got something and head() it, to avoid the PolicyException business.

btrahan updated this revision to Unknown Object (????).Oct 14 2013, 7:26 PM

avoid try / catch by doing an execute()