Page MenuHomePhabricator

Maniphest - add support for !assign command
ClosedPublic

Authored by btrahan on Oct 14 2013, 7:18 PM.
Tags
None
Referenced Files
F15430790: D7307.diff
Mon, Mar 24, 8:59 AM
F15419370: D7307.diff
Fri, Mar 21, 5:39 AM
F15418224: D7307.id16456.diff
Thu, Mar 20, 9:43 PM
F15407503: D7307.id16457.diff
Tue, Mar 18, 5:54 PM
F15390980: D7307.id16455.diff
Sat, Mar 15, 7:39 AM
F15390356: D7307.id16456.diff
Sat, Mar 15, 6:09 AM
F15300740: D7307.id.diff
Mar 5 2025, 5:04 PM
Unknown Object (File)
Feb 14 2025, 12:59 PM

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPd0127f95e541: Maniphest - add support for !assign command
Summary

also try to centralize some of the command parsing logic. note that differential is still an exception here. it uses a whitelist-style regex. i think long-term we should have this for every app but changing it seemed too big for this diff.

Fixes T3937.

Test Plan

echo '!assign btrahan' | ./bin/mail receive-test --as xerxes --to T22 ; echo '!claim' | ./bin/mail receive-test --as xerxes --to T22

unit tests passed, though my new one is silly

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Nice, this is definitely a lot cleaner. Agreed on the long term vision and also on there being more mess here than fits in one diff.

src/applications/maniphest/mail/ManiphestReplyHandler.php
95–102

Maybe just execute() and then check if you got something and head() it, to avoid the PolicyException business.

btrahan updated this revision to Unknown Object (????).Oct 14 2013, 7:26 PM

avoid try / catch by doing an execute()