Page MenuHomePhabricator

Maniphest - add support for !assign command
ClosedPublic

Authored by btrahan on Oct 14 2013, 7:18 PM.
Tags
None
Referenced Files
F18766812: D7307.id.diff
Tue, Oct 7, 6:41 PM
F18762584: D7307.diff
Mon, Oct 6, 7:43 PM
F18734477: D7307.id.diff
Tue, Sep 30, 10:54 PM
F18486192: D7307.id.diff
Sep 3 2025, 6:07 PM
F18471237: D7307.diff
Sep 2 2025, 7:01 PM
F18436285: D7307.id16455.diff
Aug 31 2025, 10:56 AM
F18435646: D7307.diff
Aug 31 2025, 10:15 AM
F18431877: D7307.id16456.diff
Aug 31 2025, 5:48 AM

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPd0127f95e541: Maniphest - add support for !assign command
Summary

also try to centralize some of the command parsing logic. note that differential is still an exception here. it uses a whitelist-style regex. i think long-term we should have this for every app but changing it seemed too big for this diff.

Fixes T3937.

Test Plan

echo '!assign btrahan' | ./bin/mail receive-test --as xerxes --to T22 ; echo '!claim' | ./bin/mail receive-test --as xerxes --to T22

unit tests passed, though my new one is silly

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Nice, this is definitely a lot cleaner. Agreed on the long term vision and also on there being more mess here than fits in one diff.

src/applications/maniphest/mail/ManiphestReplyHandler.php
95–102

Maybe just execute() and then check if you got something and head() it, to avoid the PolicyException business.

btrahan updated this revision to Unknown Object (????).Oct 14 2013, 7:26 PM

avoid try / catch by doing an execute()