Page MenuHomePhabricator

Make PhabricatorPolicyInterface require a getPHID() method
ClosedPublic

Authored by epriestley on Oct 14 2013, 6:41 PM.
Tags
None
Referenced Files
F14377883: D7306.diff
Sat, Dec 21, 1:48 AM
Unknown Object (File)
Thu, Dec 19, 12:26 AM
Unknown Object (File)
Thu, Dec 12, 8:19 PM
Unknown Object (File)
Sun, Dec 8, 12:52 PM
Unknown Object (File)
Thu, Dec 5, 2:29 PM
Unknown Object (File)
Thu, Dec 5, 2:57 AM
Unknown Object (File)
Tue, Dec 3, 4:00 AM
Unknown Object (File)
Sun, Dec 1, 1:28 AM
Subscribers
Tokens
"Haypence" token, awarded by btrahan.

Details

Summary

Ref T603. This cleans up an existing callsite in the policy filter, and opens up some stuff in the future.

Some policy objects don't have real PHIDs:

PhabricatorTokenGiven
PhabricatorSavedQuery
PhabricatorNamedQuery
PhrequentUserTime
PhabricatorFlag
PhabricatorDaemonLog
PhabricatorConduitMethodCallLog
ConduitAPIMethod
PhabricatorChatLogEvent
PhabricatorChatLogChannel

Although it would be reasonable to add real PHIDs to some of these (like ChatLogChannel), it probably doesn't make much sense for others (DaemonLog, MethodCallLog). Just let them return null.

Also remove some duplicate $id and $phid properties. These are declared on PhabricatorLiskDAO and do not need to be redeclared.

Test Plan

Ran the testEverythingImplemented unit test, which verifies that all classes conform to the interface.

Diff Detail

Branch
pperm2
Lint
Lint Passed
Unit
Tests Passed