Paths

Table of Contentst

Improve an awkward initialization behavior in Javelin in Firefox
ClosedPublic
Actions

Authored by epriestley on Oct 11 2013, 12:40 PM.

Tags

None

Referenced Files

	F14478280: D7288.diff
	Sat, Dec 28, 5:06 PM

	Unknown Object (File)
	Thu, Dec 12, 6:21 AM

	Unknown Object (File)
	Mon, Dec 9, 12:56 AM

	Unknown Object (File)
	Sun, Dec 8, 6:34 AM

	Unknown Object (File)
	Wed, Dec 4, 11:54 PM

	Unknown Object (File)
	Sat, Nov 30, 10:43 AM

	Unknown Object (File)
	Nov 27 2024, 11:52 AM

	Unknown Object (File)
	Nov 23 2024, 3:25 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPa0913db5dfa5: Improve an awkward initialization behavior in Javelin in Firefox

Summary

See comment; see IRC. This didn't cause anything bad, but ended up with document.body.id == "null" in Firefox, which is a bit weird.

Test Plan

Loaded page, put document.body.null into the console, got consistent results.

Diff Detail

Branch

docbodynull

Lint

Lint Errors

Severity	Location	Code	Message
Error	webroot/rsrc/externals/javelin/core/init.js:214	JSHintW060	JSHintW060

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Oct 11 2013, 10:26 PM

btrahan added inline comments.

webroot/rsrc/externals/javelin/core/init.js
78	this line is a little weird in general with the && junk. yay firefox.

Closed by commit rPa0913db5dfa5 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__celerity_resource_map__.php

2 lines

webroot/

rsrc/

externals/

javelin/

core/

init.js

10 lines

Diff 16406

View Options

src/__celerity_resource_map__.php