Fix issue reported from github
ClosedPublic
Actions

Authored by btrahan on Oct 10 2013, 10:05 PM.

Tags

None

Referenced Files

	F15383224: D7284.id16399.diff
	Fri, Mar 14, 3:52 PM

	F15380238: D7284.diff
	Fri, Mar 14, 2:09 AM

	Unknown Object (File)
	Feb 27 2025, 3:13 AM

	Unknown Object (File)
	Feb 6 2025, 8:10 AM

	Unknown Object (File)
	Feb 1 2025, 7:40 PM

	Unknown Object (File)
	Jan 29 2025, 4:32 AM

	Unknown Object (File)
	Jan 21 2025, 9:01 AM

	Unknown Object (File)
	Jan 11 2025, 2:15 PM

Subscribers

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPdb71bf6128c8: Fix issue reported from github

Summary

we filter the $actors above such that its possible to have no $actor anymore (if $actor is not a deliverable email address). ergo, make sure we have actor before we start calling methods.

Fixes github issue 403

Test Plan

logic on this one - not 100% sure how to easily reproduce

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Ah, thanks. I took a peek at this and imagined writing a similar patch, but then forgot about it instead. Pretty sure this is the way to go, though.

Closed by commit rPdb71bf6128c8 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

storage/

PhabricatorMetaMTAMail.php

11 lines

Diff 16399

View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Fix issue reported from githubClosedPublicActions