Fix issue reported from github
ClosedPublic
Actions

Authored by btrahan on Oct 10 2013, 10:05 PM.

Tags

None

Referenced Files

	F18193339: D7284.id16398.diff
	Sun, Aug 17, 5:18 AM

	F18172993: D7284.id.diff
	Fri, Aug 15, 7:21 PM

	F18114515: D7284.diff
	Wed, Aug 13, 4:46 AM

	F17699279: D7284.id.diff
	Jul 15 2025, 7:52 PM

	Unknown Object (File)
	Jun 1 2025, 10:26 PM

	Unknown Object (File)
	May 28 2025, 11:50 AM

	Unknown Object (File)
	Apr 21 2025, 9:46 PM

	Unknown Object (File)
	Mar 14 2025, 3:52 PM

Subscribers

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPdb71bf6128c8: Fix issue reported from github

Summary

we filter the $actors above such that its possible to have no $actor anymore (if $actor is not a deliverable email address). ergo, make sure we have actor before we start calling methods.

Fixes github issue 403

Test Plan

logic on this one - not 100% sure how to easily reproduce

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Ah, thanks. I took a peek at this and imagined writing a similar patch, but then forgot about it instead. Pretty sure this is the way to go, though.

Closed by commit rPdb71bf6128c8 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

storage/

PhabricatorMetaMTAMail.php

11 lines

Diff 16399

View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Fix issue reported from githubClosedPublicActions