Added some sample rcsdiffs for adding and deleting a line from a file. Wrote some test cases to be tested by ArcanistDiffParser.
Unit Tests Skipped
Is this newline in the original? I can't reproduce it with rcsdiff -- my output looks like:
+++ a/testing.php 2013/03/11 16:46:19
i.e., all on one line
Okay, I made these changes:
And produced these two beautiful diffs:
...plus passing unit tests. Check if my inlines are on track and then I think we're in business?
This should just be .rcsdiff, not .rcs.diff.
(It looks like these are spaces in the files, but tabs from rcsdiff.)
If you think Lint is just bossing you around... Ignore it. You have good reason to. It's just a machine executing some slow and bad code, he can never know better than you.
Ok, Google's an exception. Listen to Google. It knows advise and wisdom. But still, it won't lint code for you.