I submitted a github pull request (https://github.com/facebook/phabricator/pull/189) before I remembered that I should arc diff instead. The stuff in this diff is a bit different from the gh pull request because arc lint bosses me around.
Details
Details
Diff Detail
Diff Detail
- Branch
- punchcard
- Lint
Lint Warnings Severity Location Code Message Warning externals/raphael/g.raphael.dot.js:1 JAVELIN5 `javelinsymbols` Binary Not Built - Unit
No Test Coverage
Event Timeline
Comment Actions
Haha, see GitHub. I think this is pretty cool but I want to clean it up a bit -- for example, the feed query will select stories related to you currently (e.g., someone updated a revision you are a reviewer for) not just your activity, and the calculation of hours uses server time when it should use the user's local time. Raphael also has enough weird glitchy things that I'm tempted to try d3.js. I'll see if I can do a pass on this once I get a chance.
Comment Actions
This feature might be the key to unlocking growth, but the design needs a little polish. Gently placing back in your queue for 2018.