Page MenuHomePhabricator

GitHub-style punchcards
AbandonedPublic

Authored by epriestley on Aug 21 2012, 11:49 PM.
Tags
None
Referenced Files
F18777109: D3357.id.diff
Sat, Oct 11, 12:57 AM
F18739114: D3357.id.diff
Wed, Oct 1, 7:49 PM
F18733965: D3357.diff
Sep 30 2025, 10:45 PM
F18442714: D3357.id.diff
Aug 31 2025, 5:40 PM
F18426317: D3357.diff
Aug 30 2025, 10:41 PM
F18044697: D3357.id6539.diff
Aug 3 2025, 7:39 AM
F17913394: D3357.id.diff
Jul 29 2025, 5:46 PM
F17886105: D3357.diff
Jul 29 2025, 12:47 AM
Subscribers
Tokens
"Love" token, awarded by qgil."Like" token, awarded by nmalcolm.

Details

Reviewers
chad
Summary

I submitted a github pull request (https://github.com/facebook/phabricator/pull/189) before I remembered that I should arc diff instead. The stuff in this diff is a bit different from the gh pull request because arc lint bosses me around.

Test Plan

Yes.

Diff Detail

Branch
punchcard
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningexternals/raphael/g.raphael.dot.js:1JAVELIN5`javelinsymbols` Binary Not Built
Unit
No Test Coverage

Event Timeline

epriestley edited reviewers, added: mshang; removed: epriestley.

Haha, see GitHub. I think this is pretty cool but I want to clean it up a bit -- for example, the feed query will select stories related to you currently (e.g., someone updated a revision you are a reviewer for) not just your activity, and the calculation of hours uses server time when it should use the user's local time. Raphael also has enough weird glitchy things that I'm tempted to try d3.js. I'll see if I can do a pass on this once I get a chance.

chad requested changes to this revision.Mar 24 2017, 4:26 PM
chad removed a reviewer: mshang.
chad changed the visibility from "All Users" to "Public (No Login Required)".
This revision now requires changes to proceed.Mar 24 2017, 4:26 PM

This feature might be the key to unlocking growth, but the design needs a little polish. Gently placing back in your queue for 2018.

No current plans to pursue this upstream.