Page MenuHomePhabricator
Differential D21848

Update Slowvote poll status to use sensible string constants
ClosedPublic
Actions

Authored by epriestley on May 27 2022, 5:14 PM.
Tags
None
Referenced Files
F18282828: D21848.diff
Sat, Aug 23, 12:31 AM
F18110783: D21848.diff
Mon, Aug 11, 11:58 PM
F18105632: D21848.id52072.diff
Sun, Aug 10, 6:57 PM
F18097142: D21848.id.diff
Fri, Aug 8, 11:20 AM
F18093457: D21848.id52070.diff
Thu, Aug 7, 6:34 PM
F18081821: D21848.diff
Tue, Aug 5, 2:26 AM
F17941441: D21848.id52072.diff
Thu, Jul 31, 5:27 AM
F17849868: D21848.diff
Jul 27 2025, 9:12 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP809ae8175259: Update Slowvote poll status to use sensible string constants
Summary

Ref T13682. This prepares for modernizing Slowvote and exposing a more usable API.

Test Plan

Ran migrations, opened and closed polls.

Diff Detail

Repository
rP Phabricator
Branch
slowvote10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25756
Build 35584: arc lint + arc unit

Event Timeline

epriestley created this revision.May 27 2022, 5:14 PM
Owners added a subscriber: Restricted Owners Package.May 27 2022, 5:14 PM
epriestley requested review of this revision.May 27 2022, 5:14 PM
Harbormaster completed remote builds in B25756: Diff 52070.May 27 2022, 5:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 27 2022, 5:15 PM
Closed by commit rP809ae8175259: Update Slowvote poll status to use sensible string constants (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP809ae8175259: Update Slowvote poll status to use sensible string constants.

Revision Contents
Changeset List

Diff 52070

View Options

resources/sql/autopatches/20220525.slowvote.08.status-type.sql

Loading...
View Options

resources/sql/autopatches/20220525.slowvote.09.status-value.sql

Loading...
View Options

resources/sql/autopatches/20220525.slowvote.10.status-xactions.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/slowvote/constants/SlowvotePollStatus.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php

Loading...
View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteCloseTransaction.php

Loading...
View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteStatusTransaction.php

Loading...
Phabricator · Built by Phacility