Page MenuHomePhabricator
Differential D21844

Update Slowvote to use sensible string constants for response visibility
ClosedPublic
Actions

Authored by epriestley on May 26 2022, 4:58 PM.
Tags
None
Referenced Files
F13052104: D21844.diff
Fri, Apr 19, 7:08 AM
Unknown Object (File)
Mon, Apr 15, 9:00 PM
Unknown Object (File)
Tue, Apr 9, 9:30 AM
Unknown Object (File)
Fri, Apr 5, 3:53 AM
Unknown Object (File)
Thu, Apr 4, 4:29 AM
Unknown Object (File)
Thu, Mar 28, 9:40 AM
Unknown Object (File)
Sat, Mar 23, 6:54 PM
Unknown Object (File)
Mar 19 2024, 5:34 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility
Summary

Ref T13682. Migrate and update Slowvote to use API-friendly string constants for response visibility, not opaque integers.

Test Plan

Created and edited slowvotes, changing response visibility.

Diff Detail

Repository
rP Phabricator
Branch
svote4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25751
Build 35579: arc lint + arc unit

Event Timeline

epriestley created this revision.May 26 2022, 4:58 PM
Owners added a subscriber: Restricted Owners Package.May 26 2022, 4:58 PM
epriestley requested review of this revision.May 26 2022, 4:58 PM
Harbormaster completed remote builds in B25751: Diff 52061.May 26 2022, 4:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2022, 4:58 PM
Closed by commit rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility.

Revision Contents
Changeset List

Diff 52061

View Options

resources/sql/autopatches/20220525.slowvote.03.response-type.sql

Loading...
View Options

resources/sql/autopatches/20220525.slowvote.04.response-value.sql

Loading...
View Options

resources/sql/autopatches/20220525.slowvote.05.response-xactions.sql

Loading...
View Options

src/applications/slowvote/constants/SlowvotePollResponseVisibility.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
View Options

src/applications/slowvote/view/SlowvoteEmbedView.php

Loading...
View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php

Loading...
Phabricator · Built by Phacility