Page MenuHomePhabricator
Differential D21840

Update "Files" attachment table to show more attachment details and support detachment
ClosedPublic
Actions

Authored by epriestley on May 25 2022, 7:53 PM.
Tags
None
Referenced Files
F18098477: D21840.id52055.diff
Fri, Aug 8, 8:26 PM
F18092592: D21840.id.diff
Thu, Aug 7, 11:45 AM
F18091773: D21840.diff
Thu, Aug 7, 12:43 AM
F18081767: D21840.diff
Tue, Aug 5, 2:09 AM
F17847841: D21840.diff
Jul 27 2025, 6:37 AM
F17741496: D21840.id52055.diff
Jul 21 2025, 9:22 AM
F17738218: D21840.id52054.diff
Jul 20 2025, 11:10 PM
F17732863: D21840.id52054.diff
Jul 20 2025, 6:11 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP7e5f7b96404f: Update "Files" attachment table to show more attachment details and support…
Summary

Ref T13682. Make the "Attached" list in Files a bit more detailed, and add a "Detach" button.

Test Plan

Tried to detach unrelated, referenced, and attached files. Saw attached files detach.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 25 2022, 7:53 PM
epriestley created this revision.
Harbormaster completed remote builds in B25747: Diff 52054.May 25 2022, 7:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 25 2022, 7:56 PM
Closed by commit rP7e5f7b96404f: Update "Files" attachment table to show more attachment details and support… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7e5f7b96404f: Update "Files" attachment table to show more attachment details and support….

Revision Contents
Changeset List

PathSize
src/
applications/
files/
application/
2 lines
controller/
PhabricatorFileDetachController.php
PhabricatorFileUICurtainAttachController.php
82 lines
5 lines
98 lines
storage/
16 lines
infrastructure/
internationalization/
translation/
7 lines

Diff 52055

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDetachController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileUICurtainAttachController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileViewController.php

Loading...
View Options

src/applications/files/storage/PhabricatorFileAttachment.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility