Page MenuHomePhabricator

Don't consider file references inside quoted text blocks to grant "attachment intent"
ClosedPublic

Authored by epriestley on May 20 2022, 6:23 PM.
Tags
None
Referenced Files
F18624814: D21833.diff
Mon, Sep 15, 9:06 PM
F18601184: D21833.diff
Sat, Sep 13, 11:44 AM
F18591662: D21833.diff
Fri, Sep 12, 9:48 AM
F18591018: D21833.diff
Fri, Sep 12, 7:58 AM
F18591016: D21833.diff
Fri, Sep 12, 7:58 AM
F18580873: D21833.diff
Thu, Sep 11, 4:32 AM
F18514323: D21833.id52043.diff
Fri, Sep 5, 10:09 AM
F18511796: D21833.diff
Fri, Sep 5, 7:05 AM
Subscribers
None

Details

Summary

Ref T13682. This is a marginal case, but if you quote someone else's text and it has a file reference embedded in it, that isn't good enough to generate "attachment intent".

Since you need both a reference and an explicit attachment, this should never actually affect any user-visible behavior today, but makes the ruleset more thorough.

Test Plan

Dragged and dropped a file, referencing it in either a quoted or unquoted block. Saw it attach only for a quoted block.

Diff Detail

Repository
rP Phabricator
Branch
file3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25735
Build 35563: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.