Page MenuHomePhabricator

Don't consider file references inside quoted text blocks to grant "attachment intent"
ClosedPublic

Authored by epriestley on May 20 2022, 6:23 PM.
Tags
None
Referenced Files
F19913789: D21833.id52034.diff
Fri, Apr 3, 5:44 AM
F19905792: D21833.id52034.diff
Tue, Mar 31, 7:56 PM
F19898520: D21833.id.diff
Sun, Mar 29, 1:19 PM
F19822723: D21833.diff
Mar 7 2026, 7:50 AM
F19776882: D21833.diff
Feb 22 2026, 6:16 PM
F19748603: D21833.id52034.diff
Feb 15 2026, 7:15 PM
F19623963: D21833.diff
Feb 4 2026, 5:22 PM
F19599409: D21833.diff
Feb 3 2026, 12:43 AM
Subscribers
None

Details

Summary

Ref T13682. This is a marginal case, but if you quote someone else's text and it has a file reference embedded in it, that isn't good enough to generate "attachment intent".

Since you need both a reference and an explicit attachment, this should never actually affect any user-visible behavior today, but makes the ruleset more thorough.

Test Plan

Dragged and dropped a file, referencing it in either a quoted or unquoted block. Saw it attach only for a quoted block.

Diff Detail

Repository
rP Phabricator
Branch
file3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25735
Build 35563: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.