Page MenuHomePhabricator

Don't consider file references inside quoted text blocks to grant "attachment intent"
ClosedPublic

Authored by epriestley on May 20 2022, 6:23 PM.
Tags
None
Referenced Files
F19024242: D21833.diff
Mon, Nov 24, 2:45 AM
F19017916: D21833.diff
Sun, Nov 23, 9:51 AM
F18900225: D21833.id.diff
Nov 7 2025, 8:37 PM
F18877414: D21833.diff
Nov 6 2025, 8:14 AM
F18869141: D21833.diff
Nov 4 2025, 10:03 AM
F18836316: D21833.diff
Oct 26 2025, 11:54 PM
F18835822: D21833.diff
Oct 26 2025, 7:07 PM
F18835548: D21833.id52034.diff
Oct 26 2025, 4:44 PM
Subscribers
None

Details

Summary

Ref T13682. This is a marginal case, but if you quote someone else's text and it has a file reference embedded in it, that isn't good enough to generate "attachment intent".

Since you need both a reference and an explicit attachment, this should never actually affect any user-visible behavior today, but makes the ruleset more thorough.

Test Plan

Dragged and dropped a file, referencing it in either a quoted or unquoted block. Saw it attach only for a quoted block.

Diff Detail

Repository
rP Phabricator
Branch
file3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25735
Build 35563: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.