Generate attachment edges from drag-and-dropped files in stacked comments
AbandonedPublic
Actions

Authored by epriestley on May 19 2022, 7:30 PM.

Tags

None

Referenced Files

	F13149040: D21829.diff
	Sat, May 4, 6:11 AM

	Unknown Object (File)
	Fri, May 3, 4:59 AM

	Unknown Object (File)
	Sun, Apr 28, 5:30 PM

	Unknown Object (File)
	Sun, Apr 28, 5:14 AM

	Unknown Object (File)
	Thu, Apr 25, 1:24 AM

	Unknown Object (File)
	Tue, Apr 23, 5:04 PM

	Unknown Object (File)
	Mon, Apr 22, 9:28 AM

	Unknown Object (File)
	Sat, Apr 20, 5:59 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: Restricted Maniphest Task

Summary

Ref T13603. When users drag-and-drop files into stacked comment remarkup text areas, process the attachment metadata and attach the files.

Test Plan

Dragged-and-dropped files into a Maniphest comment, saw them attach properly.

Diff Detail

Repository

rP Phabricator

Branch

file10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25731
Build 35559: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 19 2022, 7:30 PM

epriestley created this revision.

Harbormaster completed remote builds in B25731: Diff 52019.May 19 2022, 7:30 PM

This is likely easier to implement by unifying it more closely with the non-comment pathway, and representing it as metadata on the transaction at this level (rather than as a separate transaction).

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

31 lines

Diff 52019

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Generate attachment edges from drag-and-dropped files in stacked commentsAbandonedPublicActions