Page MenuHomePhabricator

Fix a PHP 8.1 repository marker issue in Mercurial
ClosedPublic

Authored by epriestley on May 17 2022, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 5:58 PM
Unknown Object (File)
Sat, Apr 20, 4:06 PM
Unknown Object (File)
Fri, Apr 19, 8:05 AM
Unknown Object (File)
Mon, Apr 15, 9:56 PM
Unknown Object (File)
Thu, Apr 11, 9:01 AM
Unknown Object (File)
Mon, Apr 8, 3:15 AM
Unknown Object (File)
Sun, Apr 7, 12:19 PM
Unknown Object (File)
Sat, Apr 6, 9:18 PM
Subscribers
None

Details

Summary

Ref T13588. "arc-ls-markers" emits a "branch-state" marker so callers can identify which branch is active in the working copy.

This marker doesn't have an associated commit, so trying to generate a display name fails under stricter PHP 8.1 rules when we try to substr(null, ...).

Don't attempt to generate a display name for markers with no commit hash.

Test Plan
  • Ran arc branches under PHP 8.1 in a Mercurial repository.
  • Before: fatal.
  • After: sensible output.

Diff Detail

Repository
rARC Arcanist
Branch
marker1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25724
Build 35552: arc lint + arc unit