Page MenuHomePhabricator

Straggling fixes for PhutilURI under PHP 8.1
ClosedPublic

Authored by epriestley on May 12 2022, 10:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 21, 6:31 AM
Unknown Object (File)
Wed, Jul 17, 5:11 AM
Unknown Object (File)
Sat, Jul 13, 9:30 AM
Unknown Object (File)
Sat, Jul 13, 2:16 AM
Unknown Object (File)
Tue, Jul 9, 6:27 AM
Unknown Object (File)
Tue, Jul 9, 3:14 AM
Unknown Object (File)
Mon, Jul 8, 8:25 AM
Unknown Object (File)
Tue, Jun 25, 1:05 PM
Subscribers
None

Details

Summary

Ref T13588. Additional PhutilURI fixes for PHP 8.1.

Test Plan

Ran "arc unit --everything" in Phabricator.

Diff Detail

Repository
rARC Arcanist
Branch
unit2
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25721
Build 35549: arc lint + arc unit

Unit TestsFailed

TimeTest
1,019 msArcanistBundleTestCase::testGitRepository
EXCEPTION (Exception): This patch has binary data. The PHP zlib extension is required to apply patches with binary data to git. Install the PHP zlib extension to continue. #0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(823): ArcanistBundle::newBase85Data('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...', '\n') #1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(813): ArcanistBundle->emitBinaryDiffBody('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...')
0 msArcanistBaseCommitParserTestCase::testBasics
2 assertion(s) passed.
0 msArcanistBaseCommitParserTestCase::testHalt
1 assertion(s) passed.
0 msArcanistBaseCommitParserTestCase::testJump
1 assertion(s) passed.
0 msArcanistBaseCommitParserTestCase::testJumpReturn
1 assertion(s) passed.
View Full Test Results (1 Failed · 74 Passed)

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 17 2022, 11:08 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.