Differential D21822

Straggling fixes for PhutilURI under PHP 8.1
ClosedPublic
Actions

Authored by epriestley on May 12 2022, 10:38 PM.

Tags

None

Referenced Files

	F14449574: D21822.diff
	Thu, Dec 26, 10:38 PM

	F14446968: D21822.id52005.diff
	Thu, Dec 26, 1:45 PM

	F14439346: D21822.id52005.diff
	Thu, Dec 26, 4:12 AM

	Unknown Object (File)
	Wed, Dec 25, 6:29 PM

	Unknown Object (File)
	Wed, Dec 25, 8:22 AM

	Unknown Object (File)
	Tue, Dec 24, 10:23 PM

	Unknown Object (File)
	Tue, Dec 24, 12:34 PM

	Unknown Object (File)
	Tue, Dec 24, 2:36 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rARC942b54a6977a: Straggling fixes for PhutilURI under PHP 8.1

Summary

Ref T13588. Additional PhutilURI fixes for PHP 8.1.

Test Plan

Ran "arc unit --everything" in Phabricator.

Diff Detail

Repository

Branch

unit2

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25721
Build 35549: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,019 ms	ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): This patch has binary data. The PHP zlib extension is required to apply patches with binary data to git. Install the PHP zlib extension to continue. #0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(823): ArcanistBundle::newBase85Data('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...', '\n') #1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(813): ArcanistBundle->emitBinaryDiffBody('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...')
	0 ms	ArcanistBaseCommitParserTestCase::testBasics 2 assertion(s) passed.
	0 ms	ArcanistBaseCommitParserTestCase::testHalt 1 assertion(s) passed.
	0 ms	ArcanistBaseCommitParserTestCase::testJump 1 assertion(s) passed.
	0 ms	ArcanistBaseCommitParserTestCase::testJumpReturn 1 assertion(s) passed.
		View Full Test Results (1 Failed · 74 Passed)

Event Timeline

epriestley requested review of this revision.May 12 2022, 10:38 PM

epriestley created this revision.

Harbormaster completed remote builds in B25721: Diff 52002.May 12 2022, 10:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 17 2022, 11:08 PM

This revision was landed with ongoing or failed builds.

Closed by commit rARC942b54a6977a: Straggling fixes for PhutilURI under PHP 8.1 (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC942b54a6977a: Straggling fixes for PhutilURI under PHP 8.1.

Revision Contents
Changeset List

Path

Size

src/

parser/

4 lines

Diff 52002

src/parser/PhutilURI.php

Loading...