Page MenuHomePhabricator
Differential D21821

Fix some test suite stragglers with PHP 8.1 compatibility
ClosedPublic
Actions

Authored by epriestley on May 12 2022, 10:37 PM.
Tags
None
Referenced Files
F18252031: D21821.id.diff
Thu, Aug 21, 6:59 PM
F18233336: D21821.diff
Wed, Aug 20, 4:36 PM
F18106706: D21821.id.diff
Sun, Aug 10, 11:12 PM
F18045625: D21821.diff
Sun, Aug 3, 9:26 AM
F17946769: D21821.diff
Thu, Jul 31, 3:05 PM
F17942708: D21821.id52001.diff
Thu, Jul 31, 7:03 AM
F17868761: D21821.id.diff
Jul 28 2025, 9:36 AM
F17866685: D21821.id52017.diff
Jul 28 2025, 4:53 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rPee6e2a396fec: Fix some test suite stragglers with PHP 8.1 compatibility
Summary

Ref T13588. This allows "arc unit --everything" to more or less run cleanly on PHP 8.1.

Test Plan

Ran "arc unit --everything".

Diff Detail

Repository
rP Phabricator
Branch
file9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25720
Build 35548: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 12 2022, 10:37 PM
epriestley created this revision.
Harbormaster completed remote builds in B25720: Diff 52001.May 12 2022, 10:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 7:04 PM
Closed by commit rPee6e2a396fec: Fix some test suite stragglers with PHP 8.1 compatibility (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPee6e2a396fec: Fix some test suite stragglers with PHP 8.1 compatibility.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
parser/
ics/
4 lines
files/
format/
__tests__/
4 lines
nuance/
github/
2 lines
infrastructure/
markup/
blockrule/
2 lines
markuprule/
4 lines

Diff 52001

View Options

src/applications/calendar/parser/ics/PhutilICSWriter.php

Loading...
View Options

src/applications/files/format/__tests__/PhabricatorFileStorageFormatTestCase.php

Loading...
View Options

src/applications/nuance/github/NuanceGitHubRawEvent.php

Loading...
View Options

src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php

Loading...
View Options

src/infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php

Loading...
Phabricator · Built by Phacility