In Drydock, yield for reclaiming resources in the "released" state
ClosedPublic
Actions

Authored by epriestley on May 9 2022, 5:45 PM.

Tags

None

Referenced Files

	F18484919: D21809.diff
	Wed, Sep 3, 5:11 PM

	F18345577: D21809.diff
	Tue, Aug 26, 11:50 AM

	F18106693: D21809.id.diff
	Aug 10 2025, 11:12 PM

	F18093760: D21809.id.diff
	Aug 7 2025, 8:27 PM

	F18087073: D21809.diff
	Aug 6 2025, 2:11 AM

	F18044463: D21809.diff
	Aug 3 2025, 7:14 AM

	F17924339: D21809.id51984.diff
	Jul 30 2025, 9:49 AM

	F17861314: D21809.diff
	Jul 27 2025, 10:42 PM

View All Files

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13677: Drydock may grow resource pools too cautiously
Commits: rPa640a4a4930f: In Drydock, yield for reclaiming resources in the "released" state

Summary

Ref T13677. This was an accidental change in D21807: when reclaiming a resource, wait for it to be completely destroyed before allowing a lease to reclaim another resource.

Test Plan

Reverts accidental behavior change in D21807.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 9 2022, 5:45 PM

Owners added a subscriber: Restricted Owners Package.May 9 2022, 5:45 PM

epriestley requested review of this revision.May 9 2022, 5:45 PM

Harbormaster completed remote builds in B25706: Diff 51983.May 9 2022, 5:45 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 9 2022, 5:45 PM

Closed by commit rPa640a4a4930f: In Drydock, yield for reclaiming resources in the "released" state (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa640a4a4930f: In Drydock, yield for reclaiming resources in the "released" state.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

worker/

DrydockLeaseUpdateWorker.php

1 line

Diff 51984

View Options

src/applications/drydock/worker/DrydockLeaseUpdateWorker.php

In Drydock, yield for reclaiming resources in the "released" stateClosedPublicActions