Return STDIN, STDOUT, and STDERR file descriptors from parent process
ClosedPublic
Actions

Authored by epriestley on May 5 2022, 5:27 PM.

Details

Reviewers: None
Maniphest Tasks: T13675: Can Arcanist plausibly be compiled into a binary?
Commits: rARCfc5b228db537: Return STDIN, STDOUT, and STDERR file descriptors from parent process

Summary

Ref T13675. When a process daemonizes, it needs to close these actual file descriptors, so the calling context must provide them.

Elsewhere, modify the embedded "arc" to provide them. Then use them in place of reopening the streams.

Test Plan

Ran locally with embedded "arc", will deploy for production hangs.

Repository

rARC Arcanist

Branch

stdio1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25699
Build 35527: arc lint + arc unit

epriestley requested review of this revision.May 5 2022, 5:27 PM

epriestley created this revision.

This revision was not accepted when it landed; it landed in state Needs Review.May 5 2022, 5:27 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

utils/

17 lines