Return STDIN, STDOUT, and STDERR file descriptors from parent process
ClosedPublic
Actions

Authored by epriestley on May 5 2022, 5:27 PM.

Tags

None

Referenced Files

	F18278046: D21804.diff
	Fri, Aug 22, 8:34 PM

	F18263592: D21804.id51972.diff
	Fri, Aug 22, 9:26 AM

	F18231646: D21804.id.diff
	Wed, Aug 20, 2:33 PM

	F18231128: D21804.id51972.diff
	Wed, Aug 20, 1:40 PM

	F18220365: D21804.id51972.diff
	Tue, Aug 19, 2:32 PM

	F18215249: D21804.id51972.diff
	Tue, Aug 19, 6:33 AM

	F18212839: D21804.id51971.diff
	Tue, Aug 19, 3:24 AM

	F18207296: D21804.id51972.diff
	Mon, Aug 18, 5:18 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13675: Can Arcanist plausibly be compiled into a binary?
Commits: rARCfc5b228db537: Return STDIN, STDOUT, and STDERR file descriptors from parent process

Summary

Ref T13675. When a process daemonizes, it needs to close these actual file descriptors, so the calling context must provide them.

Elsewhere, modify the embedded "arc" to provide them. Then use them in place of reopening the streams.

Test Plan

Ran locally with embedded "arc", will deploy for production hangs.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 5 2022, 5:27 PM

epriestley created this revision.

Harbormaster completed remote builds in B25699: Diff 51971.May 5 2022, 5:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 5 2022, 5:27 PM

Closed by commit rARCfc5b228db537: Return STDIN, STDOUT, and STDERR file descriptors from parent process (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCfc5b228db537: Return STDIN, STDOUT, and STDERR file descriptors from parent process.

Revision Contents
Changeset List

Path

Size

src/

utils/

PhutilSystem.php

17 lines

Diff 51972

View Options

src/utils/PhutilSystem.php

Return STDIN, STDOUT, and STDERR file descriptors from parent processClosedPublicActions