Page MenuHomePhabricator

Don't reclaim resources that have a destroyed lease less than 3 minutes old
ClosedPublic

Authored by epriestley on May 3 2022, 10:54 PM.
Tags
None
Referenced Files
F13149753: D21803.diff
Sat, May 4, 11:12 AM
Unknown Object (File)
Fri, May 3, 12:28 AM
Unknown Object (File)
Wed, May 1, 2:01 AM
Unknown Object (File)
Mon, Apr 29, 2:36 PM
Unknown Object (File)
Sun, Apr 28, 1:49 AM
Unknown Object (File)
Sat, Apr 27, 3:55 PM
Unknown Object (File)
Wed, Apr 24, 10:41 PM
Unknown Object (File)
Wed, Apr 24, 1:00 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. The 3-minute grace period when a resource can not be reclaimed after its leases are released currently doesn't work reliably because the Resource object usually isn't actually updated when a lease is released.

Add an additional check for recently-destroyed leases, and extend the grace period if we find any.

Test Plan
  • See T13676. Ran reproduction sequence there, observed immediate resource reclamation.
  • Applied patch.
  • Ran sequence again, observed repository B wait 3 minutes to reclaim a repository A resource.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 3 2022, 10:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 10:57 PM
This revision was automatically updated to reflect the committed changes.