Page MenuHomePhabricator

Don't reclaim resources that have a destroyed lease less than 3 minutes old
ClosedPublic

Authored by epriestley on May 3 2022, 10:54 PM.
Tags
None
Referenced Files
F15396330: D21803.diff
Sun, Mar 16, 1:33 PM
F15391882: D21803.id51970.diff
Sat, Mar 15, 12:07 PM
F15391881: D21803.id51962.diff
Sat, Mar 15, 12:07 PM
F15391880: D21803.id.diff
Sat, Mar 15, 12:06 PM
F15388016: D21803.id51970.diff
Sat, Mar 15, 3:12 AM
F15387799: D21803.id.diff
Sat, Mar 15, 2:55 AM
F15377563: D21803.diff
Thu, Mar 13, 9:36 AM
F15333220: D21803.diff
Sat, Mar 8, 12:59 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. The 3-minute grace period when a resource can not be reclaimed after its leases are released currently doesn't work reliably because the Resource object usually isn't actually updated when a lease is released.

Add an additional check for recently-destroyed leases, and extend the grace period if we find any.

Test Plan
  • See T13676. Ran reproduction sequence there, observed immediate resource reclamation.
  • Applied patch.
  • Ran sequence again, observed repository B wait 3 minutes to reclaim a repository A resource.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 3 2022, 10:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 10:57 PM
This revision was automatically updated to reflect the committed changes.