Ref T13676. With increased PHP8.1 strictness around null, it seems reasonable to add some convenience parsing to "PhutilArgumentParser".
Add a helper function for parsing integers.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13676: Drydock may reclaim recently-used resources
- Commits
- rARC2969f2496188: Add an ArgumentParser helper for integers
See next change. Tried these arguments:
--count '' --count asdf --count 0 --count -3 --count 999999999999999999999999999999999999999999999234 --count 5
Got sensible parsing and appropriate feedback in all cases.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- parse1
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 25694 Build 35522: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 1,026 ms | ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): This patch has binary data. The PHP zlib extension is required to apply patches with binary data to git. Install the PHP zlib extension to continue.
#0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(823): ArcanistBundle::newBase85Data('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...', '\n')
#1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(813): ArcanistBundle->emitBinaryDiffBody('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...')
| |
| 0 ms | ArcanistBaseCommitParserTestCase::testBasics 2 assertion(s) passed. | |
| 0 ms | ArcanistBaseCommitParserTestCase::testHalt 1 assertion(s) passed. | |
| 0 ms | ArcanistBaseCommitParserTestCase::testJump 1 assertion(s) passed. | |
| 0 ms | ArcanistBaseCommitParserTestCase::testJumpReturn 1 assertion(s) passed. | |
| View Full Test Results (1 Failed · 99 Passed) |