Add an ArgumentParser helper for integers
ClosedPublic
Actions

Authored by epriestley on May 3 2022, 9:09 PM.

Tags

None

Referenced Files

	F15580106: D21799.id.diff
	Wed, May 7, 3:33 AM

	F15570739: D21799.id51963.diff
	Sun, May 4, 9:45 PM

	F15551249: D21799.id51963.diff
	Sun, Apr 27, 4:03 PM

	F15509826: D21799.diff
	Wed, Apr 16, 4:23 PM

	F15504434: D21799.id51958.diff
	Mon, Apr 14, 5:51 PM

	F15504307: D21799.id51958.diff
	Mon, Apr 14, 5:18 PM

	F15502931: D21799.diff
	Mon, Apr 14, 5:37 AM

	F15488102: D21799.id.diff
	Thu, Apr 10, 7:29 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13676: Drydock may reclaim recently-used resources
Commits: rARC2969f2496188: Add an ArgumentParser helper for integers

Summary

Ref T13676. With increased PHP8.1 strictness around null, it seems reasonable to add some convenience parsing to "PhutilArgumentParser".

Add a helper function for parsing integers.

Test Plan

See next change. Tried these arguments:

--count ''
--count asdf
--count 0
--count -3
--count 999999999999999999999999999999999999999999999234
--count 5

Got sensible parsing and appropriate feedback in all cases.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 3 2022, 9:09 PM

epriestley created this revision.

Harbormaster completed remote builds in B25694: Diff 51958.May 3 2022, 9:09 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 10:57 PM

This revision was landed with ongoing or failed builds.

Closed by commit rARC2969f2496188: Add an ArgumentParser helper for integers (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC2969f2496188: Add an ArgumentParser helper for integers.

Revision Contents
Changeset List

Path

Size

src/

parser/

argument/

PhutilArgumentParser.php

27 lines

Diff 51963

View Options

src/parser/argument/PhutilArgumentParser.php

Add an ArgumentParser helper for integersClosedPublicActions