Page MenuHomePhabricator

Fix more PHP 8.1 "strlen(null)" callsites in PhutilURI
ClosedPublic

Authored by epriestley on May 3 2022, 7:00 PM.
Tags
None
Referenced Files
F14002630: D21798.id51957.diff
Fri, Oct 25, 8:49 PM
F13997972: D21798.diff
Thu, Oct 24, 7:04 AM
F13970568: D21798.id.diff
Thu, Oct 17, 8:26 AM
Unknown Object (File)
Wed, Oct 9, 2:29 PM
Unknown Object (File)
Mon, Oct 7, 2:51 PM
Unknown Object (File)
Mon, Oct 7, 2:50 PM
Unknown Object (File)
Mon, Oct 7, 2:50 PM
Unknown Object (File)
Mon, Oct 7, 2:40 PM
Subscribers
None

Details

Summary

Ref T13676. Ref T13588. These properties on PhutilURI have flexible types, just wrap them.

Test Plan

Built a new Drydock working copy with an HTTPS URI under PHP 8.1, see T13676.

Diff Detail

Repository
rARC Arcanist
Branch
strlen1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25693
Build 35521: arc lint + arc unit

Unit TestsFailed

TimeTest
1,102 msArcanistBundleTestCase::testGitRepository
EXCEPTION (Exception): This patch has binary data. The PHP zlib extension is required to apply patches with binary data to git. Install the PHP zlib extension to continue. #0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(823): ArcanistBundle::newBase85Data('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...', '\n') #1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(813): ArcanistBundle->emitBinaryDiffBody('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...')
0 msArcanistBaseCommitParserTestCase::testBasics
2 assertion(s) passed.
0 msArcanistBaseCommitParserTestCase::testHalt
1 assertion(s) passed.
0 msArcanistBaseCommitParserTestCase::testJump
1 assertion(s) passed.
0 msArcanistBaseCommitParserTestCase::testJumpReturn
1 assertion(s) passed.
View Full Test Results (1 Failed · 74 Passed)

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 8:42 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.