Fix more PHP 8.1 "strlen(null)" callsites in PhutilURI
ClosedPublic
Actions

Authored by epriestley on May 3 2022, 7:00 PM.

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
T13676: Drydock may reclaim recently-used resources
Commits: rARCe5b92735c6dc: Fix more PHP 8.1 "strlen(null)" callsites in PhutilURI

Summary

Ref T13676. Ref T13588. These properties on PhutilURI have flexible types, just wrap them.

Test Plan

Built a new Drydock working copy with an HTTPS URI under PHP 8.1, see T13676.

Repository

rARC Arcanist

Branch

strlen1

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25693
Build 35521: arc lint + arc unit

	Time	Test
	1,102 ms	ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): This patch has binary data. The PHP zlib extension is required to apply patches with binary data to git. Install the PHP zlib extension to continue. #0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(823): ArcanistBundle::newBase85Data('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...', '\n') #1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(813): ArcanistBundle->emitBinaryDiffBody('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...')
	0 ms	ArcanistBaseCommitParserTestCase::testBasics 2 assertion(s) passed.
	0 ms	ArcanistBaseCommitParserTestCase::testHalt 1 assertion(s) passed.
	0 ms	ArcanistBaseCommitParserTestCase::testJump 1 assertion(s) passed.
	0 ms	ArcanistBaseCommitParserTestCase::testJumpReturn 1 assertion(s) passed.
		View Full Test Results (1 Failed · 74 Passed)