Page MenuHomePhabricator

Remove product literal strings in "pht()", part 10
ClosedPublic

Authored by epriestley on Apr 25 2022, 7:19 PM.
Tags
None
Referenced Files
F13233423: D21774.diff
Tue, May 21, 2:17 AM
F13198244: D21774.diff
Mon, May 13, 5:23 AM
F13183421: D21774.diff
Fri, May 10, 8:54 AM
F13181834: D21774.id51897.diff
Thu, May 9, 4:07 PM
Unknown Object (File)
Mon, May 6, 5:15 PM
Unknown Object (File)
Sat, May 4, 12:14 PM
Unknown Object (File)
Sat, May 4, 10:33 AM
Unknown Object (File)
Fri, May 3, 3:08 AM
Subscribers
None

Details

Summary

Ref T13658. This one is a little silly since I used split to divide the list of files up, and only ended up with one file in the last partition.

Test Plan

Viewed Phabricator.

Diff Detail

Repository
rP Phabricator
Branch
product12
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25666
Build 35494: arc lint + arc unit

Unit TestsFailed

TimeTest
0 msPhabricatorUnitsTestCase::testDetailedDurationFormatting
EXCEPTION (RuntimeException): Implicit conversion from float 201598.98333333334 to int loses precision #0 /Users/epriestley/dev/core/lib/arcanist/src/utils/viewutils.php(144): PhutilErrorHandler::handleError(8192, 'Implicit conver...', '/Users/epriestl...', 144) #1 /Users/epriestley/dev/core/lib/arcanist/src/utils/viewutils.php(47): phutil_format_units_generic(201598.98333333, Array, Array, 0, 59)
1 msPhabricatorAphrontViewTestCase::testHasChildren
6 assertions passed.
192 msPhabricatorCelerityTestCase::testCelerityMaps
3 assertions passed.
10 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
0 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
1 assertion passed.
View Full Test Results (1 Failed · 11 Passed)

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:23 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.