Page MenuHomePhabricator

Remove product literal strings in "pht()", part 9
ClosedPublic

Authored by epriestley on Apr 25 2022, 7:16 PM.
Tags
None
Referenced Files
F10883860: D21773.id51909.diff
Fri, Jul 1, 7:56 AM
F10883859: D21773.id51896.diff
Fri, Jul 1, 7:55 AM
F10883857: D21773.id.diff
Fri, Jul 1, 7:55 AM
F10882662: D21773.id51909.diff
Fri, Jul 1, 12:40 AM
Unknown Object (File)
Wed, Jun 29, 9:22 AM
Unknown Object (File)
Tue, Jun 28, 10:44 AM
Unknown Object (File)
Sun, Jun 26, 6:15 AM
Unknown Object (File)
Fri, Jun 24, 11:27 AM
Subscribers
None

Details

Summary

Ref T13658.

Test Plan

This test plan is non-exhaustive.

  • Ran bin/storage databases.
  • Viewed Badges UI exmaples page.
  • Used eval rule for strings.platform.server.name, got "Phabricator".

Diff Detail

Repository
rP Phabricator
Branch
product11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25665
Build 35493: arc lint + arc unit

Event Timeline

epriestley created this revision.
epriestley retitled this revision from Remove product literal strings in "pht()", part 8 to Remove product literal strings in "pht()", part 9.Apr 25 2022, 7:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:23 PM
This revision was automatically updated to reflect the committed changes.