Page MenuHomePhabricator
Differential D21771

Remove product literal strings in "pht()", part 7
ClosedPublic
Actions

Authored by epriestley on Apr 25 2022, 7:03 PM.
Tags
None
Referenced Files
F13052543: D21771.id.diff
Fri, Apr 19, 9:47 AM
F13052322: D21771.id51893.diff
Fri, Apr 19, 8:38 AM
Unknown Object (File)
Tue, Apr 9, 6:37 AM
Unknown Object (File)
Sat, Apr 6, 8:40 PM
Unknown Object (File)
Tue, Apr 2, 8:36 AM
Unknown Object (File)
Sat, Mar 30, 10:28 AM
Unknown Object (File)
Thu, Mar 28, 3:43 PM
Unknown Object (File)
Mar 10 2024, 11:30 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13658: How to rebrand Phabricator
Commits
rP67795a46ebfd: Remove product literal strings in "pht()", part 7
Summary

Ref T13658.

Test Plan

None of these strings look trivially testable, just relied on static tools.

Diff Detail

Repository
rP Phabricator
Branch
product9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25662
Build 35490: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Apr 25 2022, 7:03 PM
epriestley created this revision.
Harbormaster completed remote builds in B25662: Diff 51893.Apr 25 2022, 7:03 PM
epriestley edited the test plan for this revision. (Show Details)Apr 25 2022, 7:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:23 PM
Closed by commit rP67795a46ebfd: Remove product literal strings in "pht()", part 7 (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP67795a46ebfd: Remove product literal strings in "pht()", part 7.

Revision Contents
Changeset List

Diff 51893

View Options

src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php

Loading...
View Options

src/applications/oauthserver/application/PhabricatorOAuthServerApplication.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleApproveController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleInviteSendController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleNewController.php

Loading...
View Options

src/applications/people/mail/PhabricatorPeopleEmailLoginMailEngine.php

Loading...
View Options

src/applications/people/mail/PhabricatorPeopleUsernameMailEngine.php

Loading...
View Options

src/applications/people/mail/PhabricatorPeopleWelcomeMailEngine.php

Loading...
View Options

src/applications/people/storage/PhabricatorUserEmail.php

Loading...
View Options

src/applications/people/xaction/PhabricatorUserApproveTransaction.php

Loading...
Phabricator · Built by Phacility