Page MenuHomePhabricator

Remove product literal strings in "pht()", part 5
ClosedPublic

Authored by epriestley on Apr 25 2022, 6:24 PM.
Tags
None
Referenced Files
F10878985: D21769.id.diff
Wed, Jun 29, 10:33 AM
F10878830: D21769.diff
Wed, Jun 29, 9:19 AM
Unknown Object (File)
Thu, Jun 16, 10:09 AM
Unknown Object (File)
Thu, Jun 16, 10:09 AM
Unknown Object (File)
Thu, Jun 16, 10:09 AM
Unknown Object (File)
Thu, Jun 16, 10:09 AM
Unknown Object (File)
Mon, Jun 13, 1:32 PM
Unknown Object (File)
Sun, Jun 5, 2:36 PM
Subscribers
None

Details

Summary

Ref T13658

Test Plan

This test plan is non-exhaustive.

  • Looked at some of the config.
  • Looked at guides.

Diff Detail

Repository
rP Phabricator
Branch
product7
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25657
Build 35485: arc lint + arc unit

Unit TestsFailed

TimeTest
0 msDifferentialParseRenderTestCase::testParseRender
EXCEPTION (RuntimeException): explode(): Passing null to parameter #2 ($string) of type string is deprecated #0 [internal function]: PhutilErrorHandler::handleError(8192, 'explode(): Pass...', '/Users/epriestl...', 115) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/files/document/PhabricatorDocumentRef.php(115): explode(';', NULL)
0 msDifferentialAdjustmentMapTestCase::testBasicMaps
4 assertions passed.
0 msDifferentialAdjustmentMapTestCase::testChainMaps
1 assertion passed.
0 msDifferentialAdjustmentMapTestCase::testInverseMaps
4 assertions passed.
0 msDifferentialAdjustmentMapTestCase::testNearestMaps
10 assertions passed.
View Full Test Results (1 Failed · 22 Passed)

Event Timeline

epriestley created this revision.
  • Fix some PHP 8.1 "strlen(null)" stuff.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was automatically updated to reflect the committed changes.