Differential D21769

Remove product literal strings in "pht()", part 5
ClosedPublic
Actions

Authored by epriestley on Apr 25 2022, 6:24 PM.

Tags

None

Referenced Files

	F13097453: D21769.id51889.diff
	Thu, Apr 25, 11:56 PM

	Unknown Object (File)
	Thu, Apr 25, 2:36 AM

	Unknown Object (File)
	Tue, Apr 23, 11:05 AM

	Unknown Object (File)
	Sat, Apr 20, 5:51 PM

	Unknown Object (File)
	Fri, Apr 19, 6:44 AM

	Unknown Object (File)
	Sat, Apr 6, 1:24 AM

	Unknown Object (File)
	Wed, Apr 3, 5:30 PM

	Unknown Object (File)
	Sat, Mar 30, 10:27 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13658: How to rebrand Phabricator
Commits: rPad880491e8d6: Remove product literal strings in "pht()", part 5

Summary

Test Plan

This test plan is non-exhaustive.

Looked at some of the config.
Looked at guides.

Diff Detail

Repository

Branch

product7

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25657
Build 35485: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	DifferentialParseRenderTestCase::testParseRender EXCEPTION (RuntimeException): explode(): Passing null to parameter #2 ($string) of type string is deprecated #0 [internal function]: PhutilErrorHandler::handleError(8192, 'explode(): Pass...', '/Users/epriestl...', 115) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/files/document/PhabricatorDocumentRef.php(115): explode(';', NULL)
	0 ms	DifferentialAdjustmentMapTestCase::testBasicMaps 4 assertions passed.
	0 ms	DifferentialAdjustmentMapTestCase::testChainMaps 1 assertion passed.
	0 ms	DifferentialAdjustmentMapTestCase::testInverseMaps 4 assertions passed.
	0 ms	DifferentialAdjustmentMapTestCase::testNearestMaps 10 assertions passed.
		View Full Test Results (1 Failed · 22 Passed)

Event Timeline

epriestley requested review of this revision.Apr 25 2022, 6:24 PM

epriestley created this revision.

Harbormaster completed remote builds in B25657: Diff 51888.Apr 25 2022, 6:24 PM

Fix some PHP 8.1 "strlen(null)" stuff.

Harbormaster completed remote builds in B25658: Diff 51889.Apr 25 2022, 6:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM

Closed by commit rPad880491e8d6: Remove product literal strings in "pht()", part 5 (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPad880491e8d6: Remove product literal strings in "pht()", part 5.

Revision Contents
Changeset List

Path

Size

src/

applications/

console/

plugin/

DarkConsoleEventPlugin.php

2 lines

daemon/

application/

PhabricatorDaemonsApplication.php

2 lines

management/

PhabricatorDaemonManagementWorkflow.php

6 lines

dashboard/

paneltype/

PhabricatorDashboardQueryPanelType.php

2 lines

differential/

storage/

DifferentialDiff.php

4 lines

diffusion/

management/

DiffusionRepositoryURIsManagementPanel.php

8 lines

doorkeeper/

worker/

DoorkeeperFeedWorker.php

2 lines

feed/

config/

PhabricatorFeedConfigOptions.php

2 lines

guides/

module/

PhabricatorGuideInstallModule.php

15 lines

PhabricatorGuideQuickStartModule.php

12 lines

Diff 51888

src/applications/console/plugin/DarkConsoleEventPlugin.php

Loading...

src/applications/daemon/application/PhabricatorDaemonsApplication.php

Loading...

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Loading...

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Loading...

src/applications/differential/storage/DifferentialDiff.php

Loading...

src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php

Loading...

src/applications/doorkeeper/worker/DoorkeeperFeedWorker.php

Loading...

src/applications/feed/config/PhabricatorFeedConfigOptions.php

Loading...

src/applications/guides/module/PhabricatorGuideInstallModule.php

Loading...

src/applications/guides/module/PhabricatorGuideQuickStartModule.php

Loading...