Page MenuHomePhabricator

Remove product literal strings in "pht()", part 1
ClosedPublic

Authored by epriestley on Apr 25 2022, 5:18 PM.
Tags
None
Referenced Files
F11040292: D21765.diff
Tue, Aug 16, 7:31 AM
F11039384: D21765.id51884.diff
Tue, Aug 16, 3:57 AM
F11039338: D21765.id51901.diff
Tue, Aug 16, 3:30 AM
Unknown Object (File)
Fri, Aug 12, 3:38 PM
Unknown Object (File)
Fri, Aug 12, 11:10 AM
Unknown Object (File)
Wed, Aug 10, 1:38 PM
Unknown Object (File)
Mon, Aug 8, 11:22 PM
Unknown Object (File)
Sun, Jul 24, 4:12 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13658. I used the linter in D21763 to identify these and split them into arbitrary groups of 10 files.

Test Plan

This test plan is non-exhaustive, because some of these strings are difficult to reach.

  • Looked at "Create Service" in Almanac.
  • Used "bin/auth" to go through a one-time auth workflow (not all related strings can be hit on a single workflow).
  • Started the "Generate Keypair" worfklow in "SSH Public Keys".

Diff Detail

Repository
rP Phabricator
Branch
product3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25653
Build 35481: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was automatically updated to reflect the committed changes.