Page MenuHomePhabricator

Fix an issue where "git" may be unable to read a temporary file in Diffusion
ClosedPublic

Authored by epriestley on Apr 20 2022, 4:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:02 PM
Unknown Object (File)
Sun, Dec 15, 4:39 PM
Unknown Object (File)
Wed, Dec 11, 9:16 AM
Unknown Object (File)
Wed, Dec 11, 9:16 AM
Unknown Object (File)
Wed, Dec 11, 9:16 AM
Unknown Object (File)
Wed, Dec 11, 9:14 AM
Unknown Object (File)
Mon, Dec 9, 2:03 AM
Unknown Object (File)
Fri, Dec 6, 3:15 AM
Subscribers
None

Details

Summary

Ref T13673. After the changes in that task, we may execute "git config -l ..." as a user other than the user we used to write this temporary file.

Use "--file -" to pass the data instead, avoiding use of temporary files. This makes us agnostic to filesystem permissions.

Test Plan

Viewed a Git repository with submodules in Diffusion with "ssh.user" configured as a user relatively isolated from the webserver user.

Diff Detail

Repository
rP Phabricator
Branch
sub1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25644
Build 35472: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2022, 8:04 PM
This revision was automatically updated to reflect the committed changes.