Differential D21752

Fix a PHP 8.1 unit test failure in Projects
ClosedPublic
Actions

Authored by epriestley on Apr 1 2022, 7:08 PM.

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rPa9822a37aa5a: Fix a PHP 8.1 unit test failure in Projects

Summary

Ref T13588. This field may be "null" (and is probably never the empty string, but that's a more ambitious fix).

Test Plan

Ran unit tests, got a pass.

Diff Detail

Repository

rP Phabricator

Branch

phameint5

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25635
Build 35463: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	3 ms	PhabricatorProjectCoreTestCase::testAncestorMembers EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/project/storage/PhabricatorProject.php(414): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 414) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(1178): PhabricatorProject->save()
	2 ms	PhabricatorProjectCoreTestCase::testAncestryQueries EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/project/storage/PhabricatorProject.php(414): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 414) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(1178): PhabricatorProject->save()
	6 ms	PhabricatorProjectCoreTestCase::testApplicationPolicy EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/project/storage/PhabricatorProject.php(414): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 414) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(1178): PhabricatorProject->save()
	7 ms	PhabricatorProjectCoreTestCase::testBoardMoves EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/project/storage/PhabricatorProject.php(414): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 414) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(1178): PhabricatorProject->save()
	2 ms	PhabricatorProjectCoreTestCase::testColumnExtendedPolicies EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/project/storage/PhabricatorProject.php(414): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 414) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(1178): PhabricatorProject->save()
		View Full Test Results (23 Failed · 7 Passed)