Page MenuHomePhabricator

Make "DifferentialDiff->properties" a proper "attachable" property

Authored by epriestley on Jul 26 2021, 6:44 PM.



See PHI498. This should be initialized to "self::ATTACHABLE" like other attachable properties, but is currently initialized to "array()".

Initialize it the normal way and try to catch all code paths which may have accessed it without actually loading and attaching it.

Also, remove UI for the very old "excuse" property, which "arc" has not written for well more than a year.

Test Plan

Grepped for affected symbols, loaded various revision pages. Somewhat tricky to be 100% sure that every pathway is caught, but it should be obvious if I missed anything once someone hits the code path.

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 25520
Build 35283: Run Core Tests
Build 35282: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 26 2021, 6:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 27 2021, 8:39 PM
This revision was automatically updated to reflect the committed changes.