Paths

Table of Contentst

Differential D21701

Suppress PHP 8 deprecation warning in startup
ClosedPublic
Actions

Authored by 0 on Jul 21 2021, 12:54 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13588: PHP 8 Compatibility

Commits

rP2f1acf8b10cb: Suppress PHP 8 deprecation warning in startup

Summary

Ref T13588. See D21497. As of PHP 8, the XML entity loader is disabled by default and the libxml_disable_entity_loader function is deprecated. Thus suppress the deprecation warning for now; we could skip the function call, but this is safer.

Test Plan

Still works with PHP 7.
No more deprecation message with PHP 8.

Diff Detail

Repository

rP Phabricator

Branch

libxml-deprecation

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25484
Build 35234: Run Core Tests
Build 35233: arc lint + arc unit

Event Timeline

0 created this revision.Jul 21 2021, 12:54 AM

0 held this revision as a draft.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 21 2021, 12:54 AM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B25484: Diff 51681.Jul 21 2021, 12:55 AM

0 edited the summary of this revision. (Show Details)Jul 21 2021, 12:56 AM

This revision is a clone of D21497 for rP.

0 published this revision for review.Jul 21 2021, 1:00 AM

0 added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJul 21 2021, 1:00 AM

epriestley accepted this revision.Jul 21 2021, 1:03 AM

This revision is now accepted and ready to land.Jul 21 2021, 1:03 AM

Closed by commit rP2f1acf8b10cb: Suppress PHP 8 deprecation warning in startup (authored by 0). · Explain WhyJul 21 2021, 1:07 AM

This revision was automatically updated to reflect the committed changes.

0 added a commit: rP2f1acf8b10cb: Suppress PHP 8 deprecation warning in startup.

Revision Contents
Changeset List

Path

Size

support/

startup/

PhabricatorStartup.php

5 lines

Diff 51681

View Options

support/startup/PhabricatorStartup.php

Suppress PHP 8 deprecation warning in startupClosedPublicActions