Page MenuHomePhabricator

Add an "Authority" control to Packages to support "Watcher" packages
ClosedPublic

Authored by epriestley on Jun 25 2021, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 7:50 PM
Unknown Object (File)
Feb 4 2024, 1:02 AM
Unknown Object (File)
Jan 25 2024, 12:10 AM
Unknown Object (File)
Jan 3 2024, 7:28 PM
Unknown Object (File)
Dec 30 2023, 6:49 PM
Unknown Object (File)
Dec 30 2023, 2:08 PM
Unknown Object (File)
Dec 30 2023, 4:19 AM
Unknown Object (File)
Dec 26 2023, 9:03 PM
Subscribers
Restricted Owners Package

Details

Summary

See T13657. An install has "watcher" packages which should not allow owners to "Force Accept" other packages.

Test Plan
  • Created package A, which I own, on "/", with "Weak" authority.
  • Created package B, which I do not own, on "/src".
  • Created a revision which touches "/src" and added package B as a reviewer.
  • Attempted to accept the revision...
    • Before patch: permitted to "Force Accept" for package B.
    • After patch: not allowed to "Force Accept" for package B.
  • Verified that setting package "A" back to "Strong" authority allows a force-accept for package B.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jun 25 2021, 4:30 PM
  • Allow "owners.search" API to read this setting.

Screen Shot 2021-06-25 at 9.59.08 AM.png (239×500 px, 27 KB)

This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2021, 8:48 PM
This revision was automatically updated to reflect the committed changes.