Page MenuHomePhabricator

Add an "Authority" control to Packages to support "Watcher" packages
ClosedPublic

Authored by epriestley on Jun 25 2021, 4:30 PM.
Tags
None
Referenced Files
F19770166: D21674.id51581.diff
Thu, Feb 19, 8:58 PM
F19765279: D21674.id.diff
Thu, Feb 19, 2:26 AM
F19763851: D21674.id51581.diff
Wed, Feb 18, 8:50 PM
F19704846: D21674.diff
Wed, Feb 11, 5:43 AM
F19662399: D21674.id51583.diff
Sat, Feb 7, 9:08 AM
F19534964: D21674.diff
Jan 21 2026, 3:39 AM
F19251085: D21674.id51583.diff
Dec 22 2025, 8:22 AM
F19216119: D21674.id51583.diff
Dec 17 2025, 6:54 AM
Subscribers
Restricted Owners Package

Details

Summary

See T13657. An install has "watcher" packages which should not allow owners to "Force Accept" other packages.

Test Plan
  • Created package A, which I own, on "/", with "Weak" authority.
  • Created package B, which I do not own, on "/src".
  • Created a revision which touches "/src" and added package B as a reviewer.
  • Attempted to accept the revision...
    • Before patch: permitted to "Force Accept" for package B.
    • After patch: not allowed to "Force Accept" for package B.
  • Verified that setting package "A" back to "Strong" authority allows a force-accept for package B.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jun 25 2021, 4:30 PM
  • Allow "owners.search" API to read this setting.

Screen Shot 2021-06-25 at 9.59.08 AM.png (239×500 px, 27 KB)

This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2021, 8:48 PM
This revision was automatically updated to reflect the committed changes.