Correct an issue where "dashboard.panel.edit" fatals in the API console
ClosedPublic
Actions

Authored by epriestley on Jun 1 2021, 6:40 AM.

Details

Reviewers: None
Maniphest Tasks: T13650: Unhandled Exception accessing Conduit's dashboard.panel.edit: "Attempting to use a panel in a way that requires an implementation, but the panel implementation ("") is unknown to Phabricator."
Commits: rPa8f429cdbf4d: Correct an issue where "dashboard.panel.edit" fatals in the API console

Summary

Ref T13650. Currently, viewing the API console help page for this method fatals because it constructs a generic, untyped panel.

As a step toward improving this, generate a concrete panel type instead. This isn't the best possible fix, see T13650 for discussion.

Test Plan

Viewed "dashboard.panel.edit" API page, now saw a usable page.

Diff Detail

Repository

rP Phabricator

Branch

panel1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25372
Build 35031: Run Core Tests
Build 35030: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 1 2021, 6:40 AM

Harbormaster completed remote builds in B25372: Diff 51566.Jun 1 2021, 6:41 AM

epriestley requested review of this revision.Jun 1 2021, 6:41 AM

epriestley mentioned this in T13650: Unhandled Exception accessing Conduit's dashboard.panel.edit: "Attempting to use a panel in a way that requires an implementation, but the panel implementation ("") is unknown to Phabricator.".Jun 1 2021, 6:49 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 1 2021, 6:49 AM

Closed by commit rPa8f429cdbf4d: Correct an issue where "dashboard.panel.edit" fatals in the API console (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa8f429cdbf4d: Correct an issue where "dashboard.panel.edit" fatals in the API console.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

editor/

PhabricatorDashboardPanelEditEngine.php

11 lines

Diff 51566

View Options

src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php

Correct an issue where "dashboard.panel.edit" fatals in the API consoleClosedPublicActions