Page MenuHomePhabricator

Avoid leaving stdin in nonblocking mode after a modern prompt
ClosedPublic

Authored by epriestley on Sun, May 30, 8:31 AM.

Details

Summary

Ref T13649. Currently, "arc" may leave stdin nonblocking after showing a prompt. This can cause various odd behaviors down the line.

I can't immediately reproduce this behavior on macOS in "zsh" or "bash" (I'm unable to get stdin to remain nonblocking beyond the process lifespan), and also don't have pcntl locally so there's a fair amount of handwaving here.

Test Plan

This is somewhat speculative since I can't immediately reproduce the behavior. I tested the locally-reachable paths (no pcntl) but they're not interesting.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sun, May 30, 8:31 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.