Page MenuHomePhabricator

On inline comments, track an explicit "committed" content state
ClosedPublic

Authored by epriestley on Mar 25 2021, 9:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 10:37 PM
Unknown Object (File)
Sun, Mar 10, 1:47 PM
Unknown Object (File)
Feb 21 2024, 6:29 AM
Unknown Object (File)
Feb 21 2024, 6:29 AM
Unknown Object (File)
Feb 21 2024, 6:29 AM
Unknown Object (File)
Feb 16 2024, 7:30 AM
Unknown Object (File)
Feb 4 2024, 12:57 AM
Unknown Object (File)
Jan 26 2024, 4:05 AM
Subscribers
None

Details

Summary

Ref T13559. To allow the client to make correct decisions about what buttons mean, track an explicit "Committed" content state.

This is the last version of the comment that has been saved on the server, and does not exist if the comment has never been saved.

Test Plan

Created comments, etc. See followups.

Diff Detail

Repository
rP Phabricator
Branch
istate8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25328
Build 34971: Run Core Tests
Build 34970: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:01 PM
This revision was automatically updated to reflect the committed changes.