Page MenuHomePhabricator

Make the client authoritative for "Cancel" actions
ClosedPublic

Authored by epriestley on Mar 25 2021, 9:00 PM.

Details

Summary

Ref T13559. When the user clicks the "Cancel" button, we sometimes take it to mean "delete" (when the comment is empty).

Both the client and server make a decision about this, and they may not agree, which causes the client to fall out of sync.

Make the client responsible for deciding whether it wants to interpret a click on the "Cancel" button as a "revert" or a "delete".

Test Plan

Cancelled empty and nonempty comments, etc. See followup changes.

Diff Detail

Repository
rP Phabricator
Branch
istate6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25326
Build 34967: Run Core Tests
Build 34966: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
This revision was automatically updated to reflect the committed changes.