Page MenuHomePhabricator

Make client inlines track an "active" state
ClosedPublic

Authored by epriestley on Mar 25 2021, 8:54 PM.

Details

Summary

Ref T13559. Rather than reading from the document, make client inlines actively track their current "active" state.

The "active" state is what the user currently sees in the client UI.

Test Plan

Created inlines, etc. See followups.

Diff Detail

Repository
rP Phabricator
Branch
istate3
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/diff/DiffInlineContentState.js:27W033JSHintW033
Unit
No Test Coverage
Build Status
Buildable 25322
Build 34959: Run Core Tests
Build 34958: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
This revision was automatically updated to reflect the committed changes.