Page MenuHomePhabricator
Differential D21646

Make client inlines track an "active" state
ClosedPublic
Actions

Authored by epriestley on Mar 25 2021, 8:54 PM.
Tags
None
Referenced Files
F18852266: D21646.id.diff
Fri, Oct 31, 7:45 AM
F18782702: D21646.diff
Mon, Oct 13, 2:23 AM
F18764837: D21646.id51515.diff
Oct 7 2025, 8:11 AM
F18761321: D21646.id.diff
Oct 6 2025, 1:40 PM
F18746973: D21646.diff
Oct 3 2025, 2:05 PM
F18745917: D21646.id51538.diff
Oct 3 2025, 10:19 AM
F18705442: D21646.diff
Sep 28 2025, 11:23 AM
F18616661: D21646.diff
Sep 14 2025, 6:28 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting
Commits
rPcb00cb99e244: Make client inlines track an "active" state
Summary

Ref T13559. Rather than reading from the document, make client inlines actively track their current "active" state.

The "active" state is what the user currently sees in the client UI.

Test Plan

Created inlines, etc. See followups.

Diff Detail

Repository
rP Phabricator
Branch
istate3
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/diff/DiffInlineContentState.js:27W033JSHintW033
Unit
No Test Coverage
Build Status
Buildable 25322
Build 34959: Run Core Tests
Build 34958: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 51515.Mar 25 2021, 8:54 PM
epriestley created this revision.
  • Lint fix.
Harbormaster completed remote builds in B25322: Diff 51514.Mar 25 2021, 8:55 PM
Harbormaster completed remote builds in B25323: Diff 51515.
epriestley requested review of this revision.Mar 25 2021, 8:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
Closed by commit rPcb00cb99e244: Make client inlines track an "active" state (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPcb00cb99e244: Make client inlines track an "active" state.

Revision Contents
Changeset List

PathSize
resources/
celerity/
webroot/
rsrc/
js/
application/
diff/
29 lines
49 lines

Diff 51514

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInlineContentState.js

Loading...
Phabricator · Built by Phacility