Page MenuHomePhabricator

Correct minor "jump to symbol" behavior in Differential
ClosedPublic

Authored by epriestley on Mar 17 2021, 10:30 PM.
Tags
None
Referenced Files
F13198480: D21641.id.diff
Mon, May 13, 7:07 AM
F13186960: D21641.diff
Sat, May 11, 4:14 AM
Unknown Object (File)
Tue, May 7, 7:19 AM
Unknown Object (File)
Sun, May 5, 10:16 PM
Unknown Object (File)
Fri, May 3, 5:52 AM
Unknown Object (File)
Fri, May 3, 1:07 AM
Unknown Object (File)
Wed, May 1, 10:36 PM
Unknown Object (File)
Sat, Apr 27, 9:55 AM
Subscribers
None

Details

Summary

Ref T13644. Ref T13638.

  • Double-encode the symbol that is used as a path component, similar to Diffusion.
  • Fix an outdated reference to ".path", which provided context for symbol lookup.
  • Prevent command-clicking headers from looking up the path as a symbol.
Test Plan
  • Command-clicked headers, no longer got a symbol.
  • Command-clicked stuff with "/", saw it double-encoded and decoded properly.
  • Command-clicked normal symbols, saw "path" populate correctly.

Diff Detail

Repository
rP Phabricator
Branch
symbol1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25313
Build 34944: Run Core Tests
Build 34943: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 10:31 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.