Differential D21626

Make minor Almanac device modernization updates
ClosedPublic
Actions

Authored by epriestley on Mar 16 2021, 6:18 PM.

Details

Reviewers: None
Maniphest Tasks: T13641: Support "Disabled" devices in Almanac
Commits: rP9003a453691f: Make minor Almanac device modernization updates

Summary

Ref T13641. Provide minor modernizations before adding a "Disabled" state.

Test Plan

Browsed devices, created a new device.

Diff Detail

Repository

rP Phabricator

Branch

almanac2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25282
Build 34898: Run Core Tests
Build 34897: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 16 2021, 6:18 PM

Harbormaster completed remote builds in B25282: Diff 51474.Mar 16 2021, 6:19 PM

epriestley requested review of this revision.Mar 16 2021, 6:19 PM

epriestley edited the summary of this revision. (Show Details)Mar 16 2021, 9:23 PM

epriestley added a task: T13641: Support "Disabled" devices in Almanac.

epriestley removed a task: T13065: Move storage for `mailKey` to the Mail application.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2021, 10:52 PM

Closed by commit rP9003a453691f: Make minor Almanac device modernization updates (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP9003a453691f: Make minor Almanac device modernization updates.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

storage/

AlmanacDevice.php

12 lines

Diff 51474

View Options

src/applications/almanac/storage/AlmanacDevice.php

Make minor Almanac device modernization updatesClosedPublicActions